T09 · Insecure Skill Coding Practices
- Location
scripts/churn.py:286- Finding
Unprotected initialization overwrites existing customer datasets
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill appears purpose-built for customer churn analysis, but its initialization command can overwrite local customer, usage, ticket, and contract data without confirmation.
Review before installing if this would be used with real customer or contract records. Avoid running --init on an existing installation unless you have backups or are comfortable replacing the skill's local datasets with bundled sample data.
scripts/churn.py:286Unprotected initialization overwrites existing customer datasets
The skill advertises executable commands that read and likely write local files under ~/.qclaw/skills/pans-churn-predictor/data/, but the manifest declares no explicit tool scope such as permissions or allowed-tools. This creates an authorization ambiguity where a host agent may invoke file-capable behavior without clear least-privilege boundaries, increasing the chance of unintended data access or modification involving customer usage, tickets, and contract data.
The trigger list includes broad business phrases such as '客户成功' and 'churn prediction', which may cause the skill to activate in loosely related conversations rather than only when the user clearly intends to run this customer-risk workflow. Over-broad activation can expose sensitive customer-health data or lead the agent to perform unintended analysis in the wrong context.
The skill's natural-language description and user-facing interface strings are in Chinese throughout the file, which effectively forces a specific language for interaction. There is no indication that the user can choose another language or that the locale restriction is explicitly documented as intentional and justified.
The manifest and module/docs describe a customer churn warning and analysis tool, which implies read-oriented analytics over existing business data. However, the code includes an --init path that creates and writes multiple local datasets, turning the skill into a data-seeding tool in addition to analysis.
The --init path writes multiple local data files without checking for existing content or warning that files may be created or overwritten. In this skill's context, the risk is limited to accidental local data loss or contamination of analyst/customer records, not system compromise, but it is still an unsafe state-changing behavior.
This JSON file encodes all client names, industries, and contacts exclusively in Chinese, which constitutes a language/locale choice baked into the skill data. There is no indication in the file that users can choose another language or that the locale restriction is explicitly justified.
This JSON file uses Chinese-only organization names as the primary visible natural-language content, with no indication that the skill or dataset is intentionally region-specific or that users can choose another language/locale. Under the stated policy, a fixed language/locale can be a violation when it is imposed without opt-in or documented justification.
The JSON values for ticket issues and organization names are entirely in Chinese, with no indication that language selection is configurable or optional. Under the policy criteria, hard-coding a single language/locale without opt-in can constitute a natural-language policy violation.