Back to skill

Security audit

price-check

Security checks for vulnerabilities and agentic risk

Overview

The skill mostly performs price comparison as advertised, but it under-discloses external query sharing and tries to control the agent’s final response too rigidly.

Review this before installing if you care about privacy or agent control. Product searches may be sent to maishou88.com, local query history is retained, and optional Feishu sync can send shopping queries and results to a Feishu workspace. Avoid enabling Feishu sync unless you are comfortable with the Bitable permissions and plaintext local config, and treat the generated report as data the agent should be allowed to summarize or adapt.

Vulnerability Patterns
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Insecure DependenciesIntroduces malicious components through unsafe dependency sources
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
Findings (4)

T01 · Skill Instruction Hijacking

Error
Location
SKILL.md:14
Finding

Mandatory Agent Response Hijacking Through Skill-Controlled Rendering Rules

Content
View full analysis
Remediation
View remediation

T09 · Insecure Skill Coding Practices

Error
Location
bin/setup_feishu.py:140
Finding

Feishu Base Token Exposed Through Process Arguments, Console Output, and Unprotected Configuration Writes

Content
View full analysis
None: p = argparse.ArgumentParser(description="price-check 飞书多维表格一次性配置") p.add_argument("base_url", help="飞书多维表格 URL") p.add_argument("--profile", default=None, help="lark-cli profile 名(可选)") args = p.parse_args() base_token = parse_base_url(args.base_url) print(f"📍 base_token = {base_token}") ``` From `bin/setup_feishu.py:187-200`: ```python config["feishu_sync"] = { "enabled": True, "base_token": base_token, "table_id": table_id, "lark_cli_profile": args.profile, } CONFIG_PATH.write_text(json.dumps(config, ensure_ascii=False, indent=2), encoding="utf-8") print(f" 配置已写入 {CONFIG_PATH}") print() print("✅ 飞书同步已启用") print(f" base: {base_token}") print(f" table: {table_id}") print(" 下次跑 price-check 会自动同步到飞书表格") ``` From `bin/feishu_sync.py:45-48`: ```python def save_config(config: dict[str, Any]) -> None: CONFIG_PATH.parent.mkdir(parents=True, exist_ok=True) CONFIG_PATH.write_text(json.dumps(config, ensure_ascii=False, indent=2), encoding="utf-8") ``` ### Technical Analysis The documented setup workflow requires the Feishu Bitable URL, including its base token, to be supplied as a command-line argument. Command-line arguments may be exposed through: - Shell history. - Process inspection while setup is running. - Terminal recording and session logs. - Automation logs or support transcripts. After extraction, the base token is printed to standard output twice. The token is then written in plaintext to `~/.openclaw/data/price-check/config.json`. Neither configuration-writing path explicitly enforces restrictive permissions. The resulting permissions therefore depend on the user's umask and any p ...[truncated 1772 chars]
Remediation
View remediation

other

Warning
Location
bin/_data_layer.py:81
Finding

Misleading Local-Only Privacy Claim Despite Mandatory Third-Party Query Transmission

Content
View full analysis
Remediation
View remediation

T08 · Insecure Dependencies

Warning
Location
bin/price_check.py:1
Finding

Unpinned Aiohttp Runtime Dependency Produces Non-Reproducible Executions

Content
View full analysis
=3.10" # dependencies = ["aiohttp"] # /// ``` ### Technical Analysis The PEP 723-style script metadata declares `aiohttp` without a version constraint, lockfile reference, or integrity hash. When the documented `uv run` workflow resolves the script dependency, the exact package version can vary over time. This produces two supply-chain risks: - A future compromised or malicious package release could be selected automatically. - A legitimate but incompatible release could alter networking behavior or break security assumptions. The package name itself is correctly spelled, and no direct evidence of dependency confusion or a malicious package was found. The weakness is the absence of reproducible dependency resolution and version verification. ### Attack Path 1. The user invokes the documented `uv run bin/price_check.py` command. 2. `uv` resolves `aiohttp` without a fixed version or committed lock state. 3. The resolver downloads whichever release currently satisfies the unconstrained declaration. 4. Package installation or import executes code from that selected release in the user's context. 5. If the selected release or its transitive dependencies are compromised, attacker-controlled code can execute with the same permissions as the user running the Skill. ### Impact Assessment A compromised dependency would execute under the invoking user's operating-system account. Its potential scope could include: - Reading files accessible to that account. - Accessing the Skill's SQLite history and Feishu configuration. - Modifying user-owned files. - Sending data over the network. - Altering price results or generated reports. No evidence shows that the currently resolved `aiohttp` package is malicious ...[truncated 85 chars]
Remediation
View remediation
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Excessive AgencyUnrestricted Tool Access, Autonomous Decision Making, Scope Creep
  • Tool MisuseTool Parameter Abuse, Chaining Abuse, Unsafe Defaults
  • Rogue AgentSelf-Modification, Session Persistence
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
Findings (39)

Tool Parameter Abuse

High
Category
Tool Misuse
Confidence
90% confidence
Finding

Although scoped to the skill's own directory, the README encourages copy-pasting a forceful recursive deletion command. In an agent-skill ecosystem, destructive shell commands in documentation are risky because users may execute them blindly, and path expansion or editing mistakes can lead to broader local data loss.

Content

Scanner excerpt · README.md (reported line 143)May include surrounding context.

cp ~/.openclaw/data/price-check/price-check.db ~/Backups/

Reset (delete all data)

rm -rf ~/.openclaw/data/price-check/

text

## Roadmap

Tool Parameter Abuse

High
Category
Tool Misuse
Confidence
90% confidence
Finding

Although scoped to the skill's own directory, the README encourages copy-pasting a forceful recursive deletion command. In an agent-skill ecosystem, destructive shell commands in documentation are risky because users may execute them blindly, and path expansion or editing mistakes can lead to broader local data loss.

Content

Scanner excerpt · README.md (reported line 143)May include surrounding context.

cp ~/.openclaw/data/price-check/price-check.db ~/Backups/

Reset (delete all data)

rm -rf ~/.openclaw/data/price-check/

text

## Roadmap

Tool Parameter Abuse

High
Category
Tool Misuse
Confidence
90% confidence
Finding

Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns).

Content

Scanner excerpt · README.zh-CN.md (reported line 143)May include surrounding context.

cp ~/.openclaw/data/price-check/price-check.db ~/Backups/

重置(删除所有数据)

rm -rf ~/.openclaw/data/price-check/

text

## Roadmap

Tool Parameter Abuse

High
Category
Tool Misuse
Confidence
90% confidence
Finding

Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns).

Content

Scanner excerpt · README.zh-CN.md (reported line 143)May include surrounding context.

cp ~/.openclaw/data/price-check/price-check.db ~/Backups/

重置(删除所有数据)

rm -rf ~/.openclaw/data/price-check/

text

## Roadmap

Tp4

High
Category
MCP Tool Poisoning
Confidence
96% confidence
Finding

The skill performs local persistence/caching and optional Feishu synchronization beyond simple price lookup, which increases data handling risk relative to the stated purpose. Even if some behavior is partially documented later in the file, top-level mismatch can mislead operators about retention, external dependencies, and where user queries and result data may end up.

Content

No source excerpt is available for this finding.

Tp4

High
Category
MCP Tool Poisoning
Confidence
97% confidence
Finding

The skill performs local persistence/caching and optional Feishu synchronization beyond simple price lookup, which increases data handling risk relative to the stated purpose. Even if some behavior is partially documented later in the file, top-level mismatch can mislead operators about retention, external dependencies, and where user queries and result data may end up.

Content

No source excerpt is available for this finding.

Tp4

High
Category
MCP Tool Poisoning
Confidence
95% confidence
Finding

The skill performs local persistence/caching and optional Feishu synchronization beyond simple price lookup, which increases data handling risk relative to the stated purpose. Even if some behavior is partially documented later in the file, top-level mismatch can mislead operators about retention, external dependencies, and where user queries and result data may end up.

Content

No source excerpt is available for this finding.

Tp4

High
Category
MCP Tool Poisoning
Confidence
99% confidence
Finding

The skill performs local persistence/caching and optional Feishu synchronization beyond simple price lookup, which increases data handling risk relative to the stated purpose. Even if some behavior is partially documented later in the file, top-level mismatch can mislead operators about retention, external dependencies, and where user queries and result data may end up.

Content

No source excerpt is available for this finding.

Context-Inappropriate Capability

High
Category
Not specified by scanner
Confidence
97% confidence
Finding

The skill transmits query data and result content to Feishu via feishu_sync.sync_query_to_feishu(query, result) even though that behavior is not necessary for a price-comparison function and is only loosely labeled as opt-in in a comment. User queries may contain sensitive purchase intent, product interests, or personal shopping context, and the full result object can include cached history and derived data, creating an unnecessary third-party data exfiltration path.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
93% confidence
Finding

The README says the bot recognizes trigger keywords including 比价 / 值不值得买 / 哪里买 / 多少钱合适 / etc., but does not define a bounded list or exclusion conditions. Phrases like 哪里买 and 多少钱合适 are common shopping-language fragments and the etc. wording makes activation scope ambiguous, which could cause unintended invocations.

Content

No source excerpt is available for this finding.

Session Persistence

Medium
Category
Rogue Agent
Confidence
60% confidence
Finding

Skill establishes unauthorized persistence across sessions via cron jobs, startup scripts, or state files. Session persistence allows an attacker to maintain access beyond the current interaction.

Content

Scanner excerpt · README.md (reported line 101)May include surrounding context.

md
Sync every query (best_deal + Top 3 + history price) to a Feishu multi-dimensional table for cross-device browsing. **Default off** — only do this if you want it.

1. Install `lark-cli`
2. Create an empty Bitable in your Feishu workspace
3. Authorize your Feishu Bot app as an editor on that Bitable
4. Run the one-time setup:

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
91% confidence
Finding

The README documents a destructive reset command that permanently deletes the skill's local data directory, but it does not prominently warn that the action is irreversible. Users may copy-paste it without understanding that cached history, configuration, and any optional sync settings stored there will be lost.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
91% confidence
Finding

该处列出的触发词包括“哪里买”“多少钱合适”等较通用表达,且用“等”表示触发集合未穷尽,缺少明确边界。这会让技能在普通购物聊天或泛化咨询中被意外触发,难以判断何时会触发、何时不会。

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
88% confidence
Finding

The README documents optional synchronization of query results, links, and history to Feishu but does not clearly warn users that their shopping interests, product queries, and generated links will be transmitted to a third-party service once enabled. This can expose behavioral data and potentially sensitive purchase intent, especially if users search for medical, personal, or business-related items.

Content

No source excerpt is available for this finding.

Undeclared Tool Scope

Medium
Category
MCP Least Privilege
Confidence
96% confidence
Finding

The skill declares capabilities requiring shell, network, local file read/write, and environment access, but does not declare any explicit tool scope or permissions boundary. In an agent environment this weakens least-privilege controls, making it easier for the skill to access local data, persist user queries, or invoke external commands without clear operator awareness.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
91% confidence
Finding

The trigger list includes broad phrases like '历史价', '给我购买链接', and '当前价合理吗', which can cause accidental activation during ordinary conversation. In this skill, accidental activation is more sensitive because execution may perform network requests, local data writes, and optional remote synchronization, turning a benign chat into unintended data collection and external calls.

Content

No source excerpt is available for this finding.

Description-Behavior Mismatch

Medium
Category
Not specified by scanner
Confidence
96% confidence
Finding

The module exports query terms, pricing results, shop names, links, and history-derived fields to Feishu, an external SaaS, while the skill description emphasizes local price checking and local history storage. That creates a data-sharing behavior users may not reasonably expect, especially because search queries can reveal purchase intent or sensitive interests.

Content

No source excerpt is available for this finding.

Context-Inappropriate Capability

Medium
Category
Not specified by scanner
Confidence
92% confidence
Finding

This code implements full outbound data export capability to Feishu that is ancillary to the core price-comparison function, increasing privacy and supply-chain exposure. Even if optional, once enabled it sends user queries and shopping metadata to a third party, which broadens the attack surface and can violate user expectations if not transparently declared.

Content

No source excerpt is available for this finding.

subprocess module call

Medium
Category
Dangerous Code Execution
Confidence
70% confidence
Finding

subprocess module calls execute external commands. Without careful input validation, this enables command injection.

Content

Scanner excerpt · bin/feishu_sync.py (reported line 57)May include surrounding context.

python
if profile:
        cmd = ["lark-cli", "--profile", profile] + args
    try:
        result = subprocess.run(
            cmd, capture_output=True, text=True, timeout=timeout, check=False,
        )
        if result.returncode != 0:

Description-Behavior Mismatch

Medium
Category
Not specified by scanner
Confidence
98% confidence
Finding

The manifest promises '直接可点击的购买链接', implying links to the actual product listing or checkout target. However, the module docstring explicitly says affiliate/deep links were removed and later code only generates and returns generic platform search URLs via search_url, not direct item purchase links.

Content

No source excerpt is available for this finding.

Description-Behavior Mismatch

Medium
Category
Not specified by scanner
Confidence
90% confidence
Finding

The manifest description names many domestic platforms as supported targets, suggesting the skill can surface actionable buying locations across them. In code, native search URL templates are only implemented for Taobao/Tmall, JD, Pinduoduo, and 1688, while comments state Douyin, Kuaishou, Suning, Vipshop, and Kaola are left unsupported for web search output.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
93% confidence
Finding

The natural-language directive requires the agent to send the pre-rendered human_report verbatim and forbids translation or reorganization. Because the report content is authored in Chinese throughout the file, this effectively forces a specific language/locale on users without any opt-in or alternative language path.

Content

No source excerpt is available for this finding.

Description-Behavior Mismatch

Medium
Category
Not specified by scanner
Confidence
91% confidence
Finding

The setup script enables Feishu synchronization and persists configuration data, which expands the skill's behavior beyond the user-facing description of price lookup and recommendation. That capability broadening creates a trust and transparency issue: users may not expect external data synchronization or durable local state tied to third-party services.

Content

No source excerpt is available for this finding.

subprocess module call

Medium
Category
Dangerous Code Execution
Confidence
70% confidence
Finding

subprocess module calls execute external commands. Without careful input validation, this enables command injection.

Content

Scanner excerpt · bin/setup_feishu.py (reported line 91)May include surrounding context.

python
"""跑 lark-cli 命令,返回解析后的 JSON。失败 sys.exit。"""
    cmd = ["lark-cli"] + args
    try:
        r = subprocess.run(cmd, capture_output=True, text=True, timeout=timeout, check=False)
    except FileNotFoundError:
        sys.exit("❌ lark-cli 未安装或不在 PATH")
    if r.returncode != 0:

Context-Inappropriate Capability

Medium
Category
Not specified by scanner
Confidence
88% confidence
Finding

The script programmatically creates fields in an external Feishu base, which is a write-capability affecting third-party data structures rather than merely reading prices. In the context of a price-check skill, this is broader-than-expected behavior and can lead to unauthorized or surprising modification of a user's workspace if run without clear informed consent.

Content

No source excerpt is available for this finding.