T09 · Insecure Skill Coding Practices
- Location
scripts/pricing_model.py:72- Finding
Unvalidated pricing inputs can produce economically invalid quotations
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This RFQ skill is purpose-aligned and disclosed, but users should review its business-data and pricing effects before relying on it operationally.
Install only after connecting it to the intended Obsidian vault, Telegram channel, and email account. Review generated prices, supplier rankings, and draft emails manually, and keep explicit send confirmation enabled. Use pinned dependencies or an isolated environment for publishing/validation tools.
scripts/pricing_model.py:72Unvalidated pricing inputs can produce economically invalid quotations
scripts/pricing_strategies.py:47Pricing strategy parameters lack domain and range validation
scripts/compare_quotes.py:54Supplier quote ranking accepts invalid values and unsafe weighting parameters
README.md:111Installation guidance uses unpinned global dependencies and bypasses system package protections
The declared description promises a broad, end-to-end RFQ workflow with communications intake, storage, pricing, comparison, and drafting behavior. The actual code chunk only implements one narrow stage: comparing/ranking supplier quotes from existing JSON files in a directory. It does not process inbound emails, Telegram messages, wake phrases, vault storage, or draft outbound communications. While supplier quote comparison is part of the declared pipeline, the code does not substantiate most of the stated functionality, so the description materially overstates the implemented behavior.
The declared description presents a broad, end-to-end RFQ automation skill with communication-channel triggers and multiple stages: intake from email/Telegram, Obsidian storage, pricing, supplier comparison, and drafting outbound confirmations. The supplied code implements only one narrow stage: pricing calculation for an existing local markdown RFQ note, with optional write-back to a Pricing section. It does not interact with email, Telegram, wake phrases, supplier quotes, outbound drafting, or orchestration logic. While the pricing portion is consistent with part of the description, the actual code is materially narrower than the declared primary purpose, so this is a mismatch.
The declared description presents a broad RFQ automation skill with communications intake, storage/orchestration, quote comparison, and outbound drafting. The supplied code chunk is narrowly focused on pricing strategy calculations and markdown report generation for an existing note file. It accepts command-line subcommands, reads a local note path, computes baseline pricing from parsed line items, and optionally writes a pricing comparison section back to that file. There is no code for email/Telegram integration, trigger handling, wake phrase detection, supplier quote ingestion/comparison workflow, or drafting/sending confirmations. While pricing calculation is one subset of the declared purpose, the overall description materially overstates the implemented behavior, so this is a clear mismatch.
There is a clear description-behavior mismatch. The declared purpose is an operational procurement/RFQ automation skill with messaging and email triggers plus business workflow functions. The actual code does none of that. It is a developer utility for validating a package prior to publishing: compiling Python files, checking regex compatibility, validating YAML frontmatter, checking file references, and finding build artifacts. This is not a supporting implementation detail of the RFQ pipeline; it is a separate packaging/QA function with a materially different primary purpose.
The skill declares file read/write capable behavior but does not define any explicit tool scope such as permissions or allowed-tools. In an agent environment, this increases the chance of over-broad filesystem access, making unintended reads or writes to vault data or adjacent files more likely if the runtime grants defaults that are too permissive.
This code rewrites the user-supplied note file in place by replacing or appending a markdown section. Although the operation is gated behind the --write flag, there is no confirmation prompt and no comment/docstring near the write path warning that the original file will be modified.