T09 · Insecure Skill Coding Practices
- Location
setup.js:13- Finding
Shell Command Injection Through YUKETANG_SECRET
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill mostly fits a Rain Classroom assistant, but its installers handle credentials unsafely, run unpinned external code, and one script silently reports install telemetry.
Review this skill before installing. Use it only if you trust the YuKeTang/Rain Classroom MCP service and are comfortable granting it access to your Rain Classroom account data and class scheduling actions. Treat YUKETANG_SECRET like a password, avoid pasting it into chats or logs, and prefer a safer pinned setup path over the included unpinned npx installers; the shell installer also sends an undisclosed install report.
setup.js:13Shell Command Injection Through YUKETANG_SECRET
setup.sh:44Execution of an Unpinned npm Package Through npx
setup.sh:103Undisclosed Authenticated Installation Telemetry
The declared purpose presents the skill as a data-query tool, but the content also instructs local secret management, environment-variable updates, installation steps, and external command execution. This mismatch reduces informed consent and can trick users or reviewers into underestimating the skill's ability to influence local configuration and credential handling.
The skill clearly relies on sensitive local capabilities via environment variables (YUKETANG_SECRET), but it does not declare any explicit tool scope or permission boundary. That makes the skill harder to govern and review, and can lead to unintended credential access or broader execution than users expect from a 'query' skill.
Using npx mcporter without pinning a specific version creates a supply-chain risk because the executed package may change over time or resolve to a malicious/compromised release. Since this skill instructs installation and runtime use of the tool, an attacker controlling the package path or a bad upstream update could gain code execution on the user's machine.
The skill tells users to obtain a personal Secret and even says the agent should help update environment variables, but it does not warn that the Secret is a sensitive credential that should not be pasted into chats, logs, or unsafe contexts. This increases the chance of credential leakage through transcripts, shell history, screenshots, or overbroad agent handling.
The instruction says all relative times must use current system Beijing time as the basis, which forces a specific locale/timezone behavior. Because the file does not offer user choice or explain that the skill is limited to a China-specific operating context, this is a natural-language locale policy violation under the stated rules.
This is another instance of unpinned npx mcporter usage in operational guidance, carrying the same supply-chain and arbitrary-code-execution risk. Repeated unpinned invocation increases exposure because users may run it during setup and troubleshooting.
The example command at this line also executes mcporter through unpinned npx, so users copying the example are exposed to the same supply-chain compromise path. Example code is especially risky because it is likely to be executed verbatim.
This markdown file contains user-facing instructions, examples, and prompts exclusively in Chinese, including the title and all interaction guidance. Under the policy rule for natural-language violations, forcing a single language without user opt-in can be a locale policy issue unless the regional restriction is explicitly justified.
The reference documentation exposes an action-capable tool (cube_lesson_reservation) for scheduling classes, while the skill metadata describes the skill as providing account and class query services. This mismatch can cause an orchestrator, reviewer, or end user to under-scope the skill's authority and accidentally permit state-changing operations that were not expected, increasing the risk of unintended class creation or meeting scheduling.
The script passes a bearer token on the command line to npx mcporter, which can expose the secret to local process inspection, shell history/logging, or downstream tooling, and it modifies local MCP configuration without a clear warning or consent prompt. In this skill context, the token grants access to a classroom/account data service, so accidental disclosure could expose educational account or class information.
npx commands without a version suffix (e.g. @1.0.0) create a rug-pull risk if the upstream server is compromised and publishes a malicious update.
npx commands without a version suffix (e.g. @1.0.0) create a rug-pull risk if the upstream server is compromised and publishes a malicious update.
The script instructs the user to talk to the AI using a Chinese phrase, and the surrounding comments and messages are also exclusively in Chinese. This imposes a language expectation without user opt-in or explanation that the skill is intentionally Chinese-only.
The script invokes npx mcporter without pinning an exact package version, so installation or execution may resolve to whatever version is currently available from the registry or local environment. In a setup script that handles bearer tokens and writes MCP configuration, this creates a supply-chain risk where a compromised or incompatible package could capture secrets or alter client configuration.
This verification step also executes npx mcporter without a pinned version, exposing the user to the same package-substitution or malicious-update risk during post-install validation. Although this step is read-oriented, it still runs external code in the user's environment and could be abused if the package source is compromised.
The script again calls npx mcporter without version pinning when printing the configured entry, which keeps the attack surface open even after setup appears complete. Repeated unpinned external execution increases exposure to registry compromise, typosquatting, or unexpected package updates.
The setup script performs an additional claw_report action after configuration, which is unrelated to the user's core task of registering the MCP service. Extra remote actions in installers are risky because they expand the behavior beyond expected local setup and may transmit metadata or trigger server-side processing without clear necessity.
The script silently sends installation telemetry (durationMs and install action) to a remote service with output suppressed and no user-facing warning or consent. Silent telemetry undermines transparency and trust, and in security-sensitive setup flows it can normalize undisclosed data transmission that may later expand to more sensitive fields.
The telemetry/reporting path executes npx mcporter without version pinning while contacting the remote MCP service, combining supply-chain risk with networked data transmission. Because the script has access to the bearer token and installation context, a malicious package version could exfiltrate credentials or send unauthorized actions.
The manifest describes a rain-classroom query skill for account, class, warning-list, teaching, and homework-announcement lookups. In this file, the implemented behavior is local environment inspection and subprocess execution via npx mcporter ..., which is a packaging/setup capability rather than part of the declared query service itself.
The final instruction tells the user to speak to the AI using a Chinese phrase, and the script's user-facing text is entirely in Chinese without offering an alternative language or opt-in. This can violate language/locale policy when a skill implicitly requires a specific language without giving the user a choice.