T09 · Insecure Skill Coding Practices
- Location
handler.ts:128- Finding
Approval-required tools execute without explicit user approval
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill needs review because it presents itself as a permission-checking execution framework, but its code allows approval-required actions to continue without real approval.
Review this carefully before installing or using it as a real security boundary. It is reasonable as a prototype or reference framework, but do not rely on it to control writes, shell commands, network calls, Git changes, browser actions, or messages until approval enforcement, hook-denial handling, logging minimization, and mode-change controls are fixed.
handler.ts:128Approval-required tools execute without explicit user approval
handler.ts:138Pre-execution hook denial results are ignored
risk-classifier.ts:101Destructive network block patterns are compiled with incorrect semantics
The code claims every task is subject to permission checks, but in DEFAULT mode an APPROVE-rated tool only triggers a warning and execution continues. This creates a fail-open authorization path where writes, network access, package installs, browser/message actions, or shell execution can run without explicit user consent.
The APPROVE branch only logs 'Approval required' in DEFAULT mode and then proceeds into pre_tool_call and executeTool. Because many sensitive tools are classified as approve (exec, write, delete, curl/wget, git push, npm/pip install, browser, message), an attacker or unsafe prompt can trigger side effects without any real authorization barrier.
The entire skill description is written in Chinese and does not indicate that language selection is optional or that the skill is intended only for a Chinese-language context. Under the stated policy, forcing a specific language without user opt-in is a natural-language locale violation.
The skill describes post-task logging and memory updates but does not disclose what data is retained, where it is stored, how long it persists, or whether sensitive task content may be captured. In an agent execution framework, silent logging and memory persistence can expose prompts, file contents, credentials, or operational history beyond user expectations.
The skill presents multiple invocation styles and mode-switching commands without clearly defining the authoritative activation path or safety boundaries. In an agent framework that governs tool permissions, ambiguity can cause operators or downstream agents to invoke the wrong command set, bypass expected review steps, or assume protections are active when they are not.
The manifest uses Chinese-only natural-language fields for the skill description and author-facing metadata, and later command descriptions are also Chinese-only. This indicates a language constraint without any visible opt-in, alternative locale, or justification that the skill is intended only for a Chinese-language environment.
All user-facing command descriptions in this section are Chinese-only, which can violate language/locale policy when no alternative language option or opt-in is provided. There is also no note indicating the skill is region-specific or restricted to Chinese-speaking users.
The hook manager records full hook inputs and outputs into an internal execution log, which can include tool arguments, messages, errors, or other sensitive runtime data. In an agent framework, hooks often sit around privileged operations, so retaining raw payloads increases the chance of accidental disclosure through debugging, log export, or later compromise of process memory/application state.
The decorator forwards the full method argument list to hook execution, exposing all runtime parameters to any registered hook for that lifecycle event. Because hooks are extensibility points that may be third-party or loosely trusted, this creates a broad data-exposure surface and can leak secrets, user content, or privileged internal objects beyond the original method boundary.
The file's natural-language comments and descriptions are written in Chinese, including the primary class description and operational notes, without indicating that the skill supports other languages or that Chinese is required for a documented regional purpose. This can violate language/locale policy when a skill imposes a specific language without user opt-in.
The top-level natural-language comments are written in Chinese and present the framework description in that locale without offering any user language choice or documenting a region-specific constraint. Under the policy, language constraints should be optional or explicitly justified.
The file's descriptive comments are written in Chinese, and the implementation does not indicate any user-selectable language or a region-specific justification. Under the stated policy, forcing a specific language without opt-in can be a locale-policy issue when embedded in skill-facing instructions or messaging.
The natural-language comments and title present the skill description entirely in Chinese alongside a bilingual title, with no indication that language is configurable or intentionally region-specific. This can violate language/locale policy when a skill implicitly requires a specific language without user opt-in.