Back to skill

Security audit

Book Hotels with Hot Spring Baths — Onsen Pools, Private Hot Spring Rooms, Ryokan Stays

Security checks for vulnerabilities and agentic risk

Overview

This hotel-booking skill is purpose-aligned overall, but it needs Review because it mandates installing and running an unpinned global CLI and can persist hidden raw user-query logs.

Review this before installing. Only use it if you are comfortable approving the flyai CLI install yourself, preferably with a pinned and verified version in a contained environment. Avoid entering sensitive personal, passport, payment, or contact details unless logging is removed or redacted, and do not let the skill append raw logs through shell commands.

Vulnerability Patterns
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Insecure DependenciesIntroduces malicious components through unsafe dependency sources
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
Findings (3)

T01 · Skill Instruction Hijacking

Error
Location
SKILL.md:9
Finding

Mandatory third-party execution and promotional output hijack agent behavior

Content
View full analysis
Remediation
View remediation

T08 · Insecure Dependencies

Warning
Location
SKILL.md:42
Finding

Unpinned global npm package installation creates supply-chain exposure

Content
View full analysis
Remediation
View remediation
`. 2. Verify package integrity against an approved digest or lockfile. 3. Prefer a project-local installation instead of `-g` to limit scope. 4. Disable lifecycle scripts where compatible, or review every lifecycle script before installation. 5. Require explicit user authorization before downloading or installing software. 6. Execute the CLI in a sandbox with minimal filesystem, environment-variable, and network access. 7. Document the package publisher, registry, reviewed version, integrity value, and update procedure. ]]>

T09 · Insecure Skill Coding Practices

Error
Location
references/runbook.md:32
Finding

Shell-interpolated execution logging permits command injection and stores raw user data

Content
View full analysis
> .flyai-execution-log.json ``` ``` ### Technical Analysis The logging schema explicitly includes `{raw input}` and executed command strings. The persistence example places the generated JSON inside a single-quoted shell argument. JSON escaping does not protect shell syntax: a single quote contained in a raw query can terminate the shell's quoted string. Subsequent shell metacharacters can then be interpreted as commands. Exploitation depends on an implementation following this shell template and interpolating untrusted data without shell-safe encod ...[truncated 1541 chars]
Remediation
View remediation
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • System Prompt LeakageDirect Leakage, Indirect Extraction, Tool-Based Exfiltration
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
  • MCP Tool PoisoningHidden Instructions, Unicode Deception, Parameter Description Injection
  • Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
Findings (7)

Direct Prompt Extraction

High
Category
System Prompt Leakage
Confidence
85% confidence
Finding

Skill contains instructions that could directly expose system prompts, internal rules, or hidden instructions to users or external parties.

Content

Scanner excerpt · SKILL.md (reported line 148)May include surrounding context.

flyai search-hotel --dest-name "Huangshan" --key-words "温泉" --sort rate_desc --check-in-date 2026-11-01 --check-out-date 2026-11-02

text

## Output Rules

1. **Conclusion first** — lead with the key finding
2. **Comparison table** with ≥ 3 results when available

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
91% confidence
Finding

The playbook defines all activation triggers exclusively in Chinese ("温泉酒店", "私汤", "温泉度假") without offering alternatives, opt-in, or documenting that the skill is intended only for Chinese-language use. This can violate language/locale policy because users are implicitly required to use a specific language to invoke the skill.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
97% confidence
Finding

The runbook explicitly requires logging the raw user_query and says the log is maintained internally, which creates unnecessary collection of potentially sensitive travel data, identifiers, contact details, or payment-related text users may type. In a travel-booking skill, users often provide highly sensitive personal information, so storing raw input without minimization, disclosure, or retention controls materially increases privacy and data-leak risk.

Content

No source excerpt is available for this finding.

Ssd 3

Medium
Category
Not specified by scanner
Confidence
98% confidence
Finding

The schema combines storage of raw natural-language user input with optional persistence to disk, making accidental retention of sensitive free-form data especially likely. Natural-language travel queries can include passport details, trip dates, addresses, companions, health preferences, and payment context, so retaining the full text increases breach impact and downstream misuse risk.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
96% confidence
Finding

The runbook instructs appending execution logs to a local file, which can persist sensitive operational and user-derived data beyond the active session and expose it to other processes, users, backups, or later compromise. Because the write is unconditional if filesystem access exists and no safeguards are described, this creates a real local data-retention and disclosure vulnerability.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Low
Category
Not specified by scanner
Confidence
93% confidence
Finding

The command hard-codes the hotel type as "民宿", which imposes a specific language/locale choice in the skill instructions. There is no indication that the user opted into Chinese-language search terms or that this locale constraint is documented as required.

Content

No source excerpt is available for this finding.

Intent-Code Divergence

Low
Category
Not specified by scanner
Confidence
91% confidence
Finding

The manifest identifies the skill as "spring-hotel," but this documentation file is titled "onsen-hotel" and repeatedly says results are powered by "flyai" and require a "flyai-cli." Those documentation statements describe a different skill/tool identity than the one declared in the manifest, creating intent-level confusion about what system actually powers booking results.

Content

No source excerpt is available for this finding.