Back to skill

Security audit

historical-sites

Security checks for vulnerabilities and agentic risk

Overview

The skill is not clearly malicious, but it asks agents to install and run an unpinned global travel CLI, force booking-link output, and persist raw user queries without adequate disclosure or controls.

Review before installing. This skill should only be used in an environment where you are comfortable installing a global npm CLI, sending travel queries to a third-party FlyAI/Fliggy service, receiving booking links, and retaining local execution logs. Prefer a pinned, pre-reviewed CLI install, disable or remove raw-query logging, and require user confirmation before any booking or externally routed action.

Vulnerability Patterns
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Insecure DependenciesIntroduces malicious components through unsafe dependency sources
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
Findings (3)

T01 · Skill Instruction Hijacking

Error
Location
SKILL.md:8
Finding

Mandatory FlyAI Workflow and Promotional Output Hijack Agent Behavior

Content
View full analysis
Remediation
View remediation

T08 · Insecure Dependencies

Warning
Location
SKILL.md:58
Finding

Automatic Installation and Execution of an Unpinned Global npm Package

Content
View full analysis
Remediation
View remediation

T09 · Insecure Skill Coding Practices

Warning
Location
references/runbook.md:8
Finding

Raw User Queries Are Persisted Through Unsafe Shell-Based Log Construction

Content
View full analysis
> .flyai-execution-log.json ``` ``` ### Technical Analysis The runbook places the complete raw user query into an execution log and recommends appending generated JSON to a hidden file. It does not define user consent, data minimization, sensitive-data redaction, file permissions, retention limits, rotation, or secure deletion. The suggested shell command is also unsafe if implemented literally. The generated JSON incorporates raw user-controlled text and is embedded inside a single-quoted shell argument. A raw query containing a single quote can terminate the quoted argument. Subsequent shell metacharacters can then be i ...[truncated 2349 chars]
Remediation
View remediation
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Excessive AgencyUnrestricted Tool Access, Autonomous Decision Making, Scope Creep
  • System Prompt LeakageDirect Leakage, Indirect Extraction, Tool-Based Exfiltration
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
  • MCP Tool PoisoningHidden Instructions, Unicode Deception, Parameter Description Injection
Findings (12)

Direct Prompt Extraction

High
Category
System Prompt Leakage
Confidence
85% confidence
Finding

Skill contains instructions that could directly expose system prompts, internal rules, or hidden instructions to users or external parties.

Content

Scanner excerpt · SKILL.md (reported line 130)May include surrounding context.

flyai search-poi --city-name "Xian" --category "历史古迹"

text

## Output Rules

1. **Conclusion first** — lead with the key finding
2. **Comparison table** with ≥ 3 results when available

Description-Behavior Mismatch

Medium
Category
Not specified by scanner
Confidence
96% confidence
Finding

The README presents the skill primarily as a historical-sites exploration tool, while also disclosing that it wraps a CLI providing real-time travel data and booking links. This mismatch can mislead users and agents about the true capability and trust boundary of the skill, increasing the chance they invoke networked booking or commerce actions without informed consent or appropriate safeguards.

Content

No source excerpt is available for this finding.

Rp1

Medium
Category
MCP Rug Pull
Confidence
91% confidence
Finding

The README instructs users to run npx skills ... without pinning a specific version, which can cause execution of whatever package/version is currently resolved from the registry at install time. In a skill ecosystem, this creates a supply-chain risk: a compromised or newly published package version could execute untrusted code on the user's machine during installation or use.

Content

No source excerpt is available for this finding.

Description-Behavior Mismatch

Medium
Category
Not specified by scanner
Confidence
94% confidence
Finding

The Chinese section repeats the same capability ambiguity, describing the skill as an exploration guide while also stating it provides real-time travel data and booking links. Inconsistent or incomplete multilingual disclosure can cause some users to underestimate the skill's transactional and networked behavior, leading to unsafe use in agent environments.

Content

No source excerpt is available for this finding.

Description-Behavior Mismatch

Medium
Category
Not specified by scanner
Confidence
91% confidence
Finding

The skill is presented as a historical-sites exploration guide, but its operational instructions strongly redirect the agent into acting as a generic Fliggy CLI booking/execution wrapper. This mismatch can mislead users and host agents about the skill’s true behavior and permissions, increasing the chance of unexpected command execution and data access beyond the narrow advertised purpose.

Content

No source excerpt is available for this finding.

Context-Inappropriate Capability

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The skill instructs the agent to install a global npm package as part of normal execution, which introduces supply-chain and arbitrary code-execution risk on the host environment. Requiring package installation for routine queries is especially dangerous because it expands impact from answering a travel question to modifying the system and trusting third-party code.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
94% confidence
Finding

The skill tells the agent to perform a global npm install without any warning that this changes the user or host system. Lack of disclosure and consent is dangerous because it can silently alter the environment, introduce persistent software, and expose the host to unreviewed package behavior.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
83% confidence
Finding

The activation condition triggers on generic words like "historical," "ancient," "ruins," and "heritage," which commonly appear in ordinary travel questions and are not tightly scoped to this specific skill. The file provides only one negative example, so it remains unclear when this skill should not activate for nearby intents such as museums, tours, or general history questions.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
96% confidence
Finding

The runbook explicitly records raw user input in an internal execution log without any documented minimization, redaction, consent, or retention limits. In a travel skill, user queries can naturally contain personal data such as names, passport/visa details, locations, booking references, or contact information, so logging the full prompt creates an avoidable privacy and data-exposure risk.

Content

No source excerpt is available for this finding.

Ssd 3

Medium
Category
Not specified by scanner
Confidence
99% confidence
Finding

This design combines storage of raw natural-language user input with persistent local logging, creating a straightforward data retention and leakage path. Because this skill supports travel-related functions like flights, hotels, visas, insurance, and rentals, user prompts may include highly sensitive personal and itinerary details, making the context more dangerous than a low-sensitivity informational skill.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
98% confidence
Finding

The runbook instructs appending execution logs to a local file, which creates persistent storage of potentially sensitive operational and user data without any warning or safeguards. Local log files are commonly overlooked, may have weak permissions, and can be read by other processes, operators, or later tooling, increasing the chance of unintended disclosure.

Content

No source excerpt is available for this finding.

Missing User Warnings

Low
Category
Not specified by scanner
Confidence
83% confidence
Finding

The README advertises real-time travel data and booking links but does not warn users that the skill may contact external services or interact with third-party booking platforms. Lack of disclosure reduces informed consent and can be risky in agentic contexts where users expect a passive informational skill rather than one that initiates network-backed travel interactions.

Content

No source excerpt is available for this finding.