T09 · Insecure Skill Coding Practices
- Location
scripts/imagegen.py:350- Finding
Server-Controlled Download Metadata Allows Writes Outside the Output Directory
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill is a mostly coherent AI image-generation wrapper, but its result downloader can be steered by API response metadata to write outside the chosen output folder.
Install only if you trust AI Hive with your prompts, reference images, and generated outputs. Use a dedicated virtual environment, avoid sensitive campaign or customer data, choose a constrained output directory, and review or patch the downloader path handling before routine use.
scripts/imagegen.py:350Server-Controlled Download Metadata Allows Writes Outside the Output Directory
SKILL.md:74Unpinned Runtime Dependency Installation Creates Supply-Chain Exposure
The declared purpose emphasizes ad-to-landing-page consistency analysis, but the described behavior includes API-key initialization, local config writes, image upload, task polling, and result download, while the promised matching-chain validation is not actually implemented. This mismatch is dangerous because users may provide sensitive prompts or reference images under the assumption of a constrained auditing skill, when the real behavior sends data to an external service and performs broader side effects.
The skill exposes capabilities that imply shell, filesystem, environment, and network access, but it does not declare any tool scope or permissions boundary. That makes the operational trust model unclear and can lead users or hosting systems to invoke a skill with broader privileges than expected, increasing the chance of unintended file access, credential use, or outbound requests.
This is a markdown file, so vague-trigger review applies. The description lists many broad phrases such as '广告图片', '效果广告', and '展示广告' without clearly constraining when this skill should activate versus other ad or image-related skills, increasing the chance of unintended invocation from common advertising-related requests.
The manifest description is written to direct usage in Chinese and does not offer a language choice or explain a justified locale restriction. Under the policy, forcing a specific language or locale without user opt-in is a natural-language policy concern.
The skill states that requests with a key are sent to a fixed external API and that results are downloaded, but it does not clearly warn that prompts and reference images will be transmitted off-platform. In an ad-creative workflow, prompts and images may contain unreleased campaign assets, customer data, or proprietary branding, so missing disclosure creates a real data-exposure risk.
The manifest emphasizes building an information-matching chain between ad creatives and landing pages, including audience context, approved claims, and click-through consistency. In contrast, the implementation simply forwards prompt, reference images, and parameters to an image generation API and then polls/downloads results; there is no landing-page retrieval, claim verification, or consistency-checking logic.
The manifest describes a Seedream 5 Lite skill for creating ad images aligned with landing-page messaging, implying a focused generation workflow. The code also exposes separate task and upload subcommands that allow querying any generation task by ID and uploading reference images independently, which are broader utility capabilities not reflected in the manifest description.
The module docstring and all user-facing instructions are written only in Chinese, and the script presents prompts, errors, and guidance exclusively in that language. Under the policy, forcing a specific language without offering a user opt-in or alternative can be a natural-language policy violation.
For an ad-image generation skill, interactive credential setup is understandable, but automatically launching a browser to a chat page with from=cli-skill and skill attribution parameters goes beyond the core image-generation purpose. This introduces a user-tracking or referral-oriented capability that is not disclosed in the manifest.