T09 · Insecure Skill Coding Practices
- Location
SKILL.md:17- Finding
Minimum Safety Limit Is Accepted but Never Enforced
- Content
View full analysis
= max_limit: command = min_output # Emergency cutoff safety_triggered = True # Clamp output to valid range command = max(min_output, min(max_output, command)) return command, safety_triggered ``` ### Technical Analysis The function accepts `min_limit` as the minimum safe measurement value, but never compares the measurement against it. It therefore appears to provide upper- and lower-bound protection while enforcing only the upper bound. Output clamping does not compensate for this omission. Clamping restricts the actuator command to a configured range, but it does not select a fail-safe action when the measured process value falls below its safe operating range. ### Attack Path 1. A sensor failure, process fault, or manipulated sensor input causes `measurement` to fall below `min_limit`. 2. The only measurement interlock, `measurement >= max_limit`, evaluates to false. 3. `safety_triggered` remains false. 4. The requested command is only clamped to the ordinary output range. 5. The control system continues operating despite the process being outside its documented lower safety boundary. ### Impact Assessment No operating-system privileges are obta ...[truncated 471 chars]- Remediation
View remediation
= max_limit: return upper_limit_safe_output, True if measurement <= min_limit: return lower_limit_safe_output, True ``` ]]>
