Back to skill

Security audit

麦当劳点餐skill

Security checks for vulnerabilities and agentic risk

Overview

The skill mostly matches its McDonald's ordering purpose, but it handles real orders and payment QR codes with unsafe command and URL handling that users should review before installing.

Install only if you trust the McDonald's MCP endpoint and are comfortable giving the skill access to your McDonald's token, saved addresses, local MCP configuration, and real order/payment workflow. Before use, prefer revising the command examples to pass data without a shell, validate payment URLs against the expected McDonald's host, and require explicit confirmation before config changes, address creation, and final order placement.

Vulnerability Patterns
  • Tool Hijacking and SpoofingModifies or replaces tools so legitimate-looking calls execute attacker logic
  • Insecure DependenciesIntroduces malicious components through unsafe dependency sources
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
Findings (4)

T09 · Insecure Skill Coding Practices

Error
Location
SKILL.md:87
Finding

Shell Command Injection Through Untrusted JSON and Text Arguments

Content
View full analysis
--menu '' ``` ```bash python3 {SKILL_DIR}/scripts/order_helper.py calorie-pairing \ --menu '' \ --nutrition-text '' \ --time-slot ``` ```bash python3 {SKILL_DIR}/scripts/order_helper.py format-order-summary \ --items '' \ --price '' \ --address '' ``` ```bash python3 {SKILL_DIR}/scripts/order_helper.py gen-pay-qr --pay-url '' ``` ### Technical Analysis The skill instructs the agent to interpolate MCP responses, menu data, nutrition text, addresses, cart contents, pricing responses, and payment URLs directly into shell commands. Wrapping a value in single quotes does not make interpolation safe if the value itself can contain a single quote. For example, a menu item, address field, nutrition entry, or remote response containing the following value can terminate the quoted argument and append a new shell command: ```text '; id > /tmp/injected # ``` The resulting command would be interpreted approximately as: ```bash python3 order_helper.py ... --menu ''; id > /tmp/injected #' ``` The Python script safely parses its arguments with `argparse`, but this occurs only after the invoking shell has parsed and executed the injected command. Therefore, the JSON parser does not mitigate this issue. The affected values originate from remote MCP responses or user-controlled order and address data. A compromised service response, malicious upstream record, or crafted user field could consequently cross the data-to-command boundary. ### Attack Path 1. An attacker causes an MCP response or user-controlled f ...[truncated 1149 chars]
Remediation
View remediation

T07 · Tool Hijacking and Spoofing

Error
Location
scripts/order_helper.py:352
Finding

Unvalidated Payment URL Can Produce a Spoofed or Malicious QR Code

Content
View full analysis
Remediation
View remediation

T09 · Insecure Skill Coding Practices

Warning
Location
scripts/order_helper.py:377
Finding

Predictable QR Output Path Allows Temporary-File Symlink Overwrite

Content
View full analysis
.png` as a symbolic link to a target file writable by the agent. 3. The user or agent invokes `gen-pay-qr`. 4. `img.save()` follows the pre-existing link and overwrites the target with QR image content. 5. Depending on the selected target, the overwrite can corrupt configuration, application data, or executable scripts owned by the invoking account. ### Impact Assessment The impact is limited to files writable by the process ...[truncated 434 chars]
Remediation
View remediation

T08 · Insecure Dependencies

Warning
Location
scripts/order_helper.py:364
Finding

Unpinned Runtime Installation Guidance Creates a Dependency Supply-Chain Risk

Content
View full analysis
Remediation
View remediation
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Excessive AgencyUnrestricted Tool Access, Autonomous Decision Making, Scope Creep
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
  • MCP Least PrivilegeUnderdeclared Capability, Wildcard Permission, Missing Permission Declaration
  • Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
Findings (6)

Undeclared Tool Scope

Medium
Category
MCP Least Privilege
Confidence
91% confidence
Finding

The skill reads environment variables and local files, but it does not declare any explicit tool scope or allowed-tools boundary. That creates a permission transparency problem: users and orchestrators may invoke a skill that can access sensitive configuration and local state without clear upfront restriction, increasing the chance of unintended data exposure or unsafe file access patterns.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
96% confidence
Finding

The trigger phrases are very broad and cover ordinary discussion like wanting McDonald's, asking what is tasty, promotions, calories, or order status. This makes accidental invocation more likely, which is especially risky here because the skill can read config, modify local files, create delivery addresses, and place real orders through an external service.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
94% confidence
Finding

The skill instructs writing to config.json, registering an MCP server in the user's home directory, creating addresses, and placing orders, but it does not require a clear upfront warning that local files and external account/order state will be modified. In combination with broad triggers, this can lead to unexpected persistence and real-world transactions without sufficiently informed user consent.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

This JSON configuration uses Chinese-only labels and item names throughout the user-facing meal definitions and calorie mappings. Because the file provides no indication that the skill is region-specific or that users can opt into a Chinese locale, it appears to enforce a specific language by default, which matches the language/locale policy violation criteria.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The module docstring and command help are entirely in Chinese, presenting the skill as Chinese-only without any opt-in, locale selection, or explanation that it is intended exclusively for a China-specific audience. This is a natural-language locale policy issue because the skill effectively imposes a language constraint on users through its user-facing interface.

Content

No source excerpt is available for this finding.

Context-Inappropriate Capability

Medium
Category
Not specified by scanner
Confidence
90% confidence
Finding

The manifest describes menu browsing, price calculation, order creation/tracking, nutrition lookup, and promotions queries through the McDonald's MCP service. This helper additionally creates local PNG payment artifacts on disk, which is a separate file-output/payment-facilitation capability not mentioned in the stated purpose.

Content

No source excerpt is available for this finding.