T09 · Insecure Skill Coding Practices
- Location
README.md:252- Finding
Persistent Storage of Potentially Sensitive Conversation Data Without Enforceable Safeguards
- Content
View full analysis
Vulnerability Details
File Location:
README.md:252-268; related operational instructions inSKILL.md:41-51andSKILL.md:94-97
Vulnerability Type: Persistent plaintext storage of potentially sensitive information
Risk Level: MediumVulnerable Instruction Snippet
markdown - **Key information**: Config values, IP addresses, API endpoints, file paths, auth tokens - **Reference status**: Whether the info has been referenced or summarized later in conversation - **Redundancy**: Repeated `ls`, `git status`, or similar outputs #### Phase 2: Extract Extracts durable information from tool outputs and conversation, categorized and written to `memory/YYYY-MM-DD.md`: - 🔵 **New facts**: IP addresses, ports, file paths, API endpoints - 🟡 **Decision records**: Why option A was chosen over B, with reasoning - 🔴 **Error solutions**: Error messages and their fixes - 🟢 **User preferences**: Explicitly stated likes or requirements - 🟣 **Task progress**: What's done, what's in progress Writing rules: - **Append-only** — never overwrites existing content - Each memory includes a brief source noteTechnical Analysis
The Skill instructs the agent to inspect the entire current conversation and its tool outputs, identify configuration values, internal network information, API endpoints, file paths, authentication material, user preferences, and operational history, and then persist selected information in daily memory files.
Persistent storage is part of the declared context-preservation functionality, but the collection scope exceeds the minimum information necessary because authentication material and broad configuration data are explicitly included among extraction targets. The append-only policy further increases exposure by preventing normal replacement or correction of previously stored sensitive values.
The README separately claims that sensitive values are redacted, but the operative i ...[truncated 2658 chars]
- Remediation
View remediation
Remediation Suggestions
- Explicitly prohibit persistence of passwords, API tokens, private keys, session cookies, authorization headers, recovery codes, and other authentication material.
- Replace the broad “save important configuration” policy with a minimal allowlist of information required to resume the task.
- Add deterministic secret detection before every write, covering common token formats, authorization headers, URLs containing credentials, private-key blocks, and high-entropy values.
- Redact sensitive values using non-reversible placeholders. Retain only safe metadata such as the secret type, purpose, and secure storage reference.
- Present the exact proposed memory entries to the user and require explicit approval before persisting them.
- Fail closed when a value cannot confidently be classified as non-sensitive.
- Create memory files with restrictive permissions and document the expected ownership and access model.
- Define retention and deletion controls so users can inspect, correct, expire, and securely remove stored entries.
- Add deduplication and update behavior rather than relying exclusively on append-only writes.
- Keep memory files out of source control, synchronization systems, diagnostics, and backups unless those systems provide appropriate encryption and access controls.
- Align
SKILL.mdwith the README security claim by making redaction a mandatory operational rule rather than an unenforced documentation statement. - Add a final post-write verification step that scans the resulting memory entry for secrets and removes the entry if validation fails.
