T09 · Insecure Skill Coding Practices
- Location
SKILL.md:41- Finding
Unfiltered Persistence of Potentially Sensitive Conversation Data
- Content
View full analysis
Vulnerability Details
File Location:
SKILL.md:41-50andSKILL.md:87-95
Vulnerability Type: Unfiltered plaintext persistence of sensitive information
Risk Level: MediumVulnerable Instructions
The following is an English translation of the relevant source instructions:
markdown 1. Extract information worth persisting from tool output and the conversation: - Newly discovered facts: addresses, configuration values, endpoints, and file paths - Decisions and reasons: why option A was selected instead of option B - Errors and solutions: records of encountered problems - User preferences: explicitly stated preferences or requirements - Task progress: completed and incomplete work 2. Append the extracted information to memory/YYYY-MM-DD.md - Use edit in append mode and never overwrite existing content - Attach a brief source description to every memory entryThe persistence rules further state:
markdown - Never discard critical information that has not been recorded; saving too much is preferable to omitting anything. - Append only: use edit to append to the memory file and never overwrite it. - Must save: important configurations, addresses, endpoints, file paths, and error solutions. - Recommended to save: decision reasons, user preferences, and task progress.Technical Analysis
The Skill intentionally scans conversation history and tool results, then writes selected information to persistent, date-based memory files. This is its declared function, but the extraction policy is excessively broad and does not define safeguards for secrets or personal data.
Configuration values, endpoints, error output, and tool results frequently contain API tokens, credentials, authorization headers, cookies, private hostnames, private IP addresses, database connection strings, personal information, or portions of environment files. The instructions do not require: ...[truncated 1993 chars]
- Remediation
View remediation
Remediation Suggestions
- Add an explicit denylist for passwords, API tokens, authorization headers, cookies, session identifiers, private keys, recovery codes, database URLs,
.envcontents, and personal data. - Detect and redact common secret formats before presenting or writing memory entries.
- Display the exact proposed memory entries and require explicit user confirmation before persisting them.
- Replace the “save more rather than less” policy with data minimization: store only information required for the continuing task.
- Store references to secret locations rather than secret values, such as “credential is stored in the configured secret manager.”
- Require restrictive file permissions and prevent memory files from being exposed through shared directories or source control.
- Define retention and deletion procedures for dated memory files.
- Treat all tool output as potentially sensitive, particularly output from environment inspection, configuration files, HTTP clients, cloud tools, and authentication systems.
- Add an explicit denylist for passwords, API tokens, authorization headers, cookies, session identifiers, private keys, recovery codes, database URLs,
