T09 · Insecure Skill Coding Practices
- Location
SKILL.md:35- Finding
Shell Command Injection Through Unsafe User-Input Interpolation
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill has a legitimate IP lookup purpose, but its shell command templates can be unsafe with untrusted input and its main lookup service uses plain HTTP.
Review before installing. Use this only for non-sensitive IP or domain lookups, prefer the HTTPS ipinfo.io path when possible, and ensure the agent validates lookup values as IP addresses or safe hostnames and passes them as literal arguments rather than through shell string interpolation.
SKILL.md:35Shell Command Injection Through Unsafe User-Input Interpolation
SKILL.md:35Primary IP Lookup Service Uses Unencrypted HTTP
The skill instructs the agent to transmit user-supplied IP addresses, domains, or even the host's public IP to third-party services via curl. This creates a real external data transmission risk, especially because the primary endpoint uses plain HTTP, allowing network observers to see requests and responses, and because querying '本机公网IP' discloses environment metadata about the host running the skill.
emoji: "🌐"
requires:
bins:
- curl
---
# IP 地址查询 IP Lookup
The skill hardcodes lang=zh-CN in its primary query endpoint, which makes the skill operate in Chinese by default rather than offering a language choice. This is a natural-language locale policy issue because the file describes support for international IPs but does not provide user opt-in or a configurable locale.