T09 · Insecure Skill Coding Practices
- Location
references/nullifiers.md:39- Finding
Random nullifier identifiers fail to enforce idempotency across repeated business operations
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This is a coherent Solana payments skill, but it needs Review because its examples affect real funds and signing credentials while several safety boundaries are under-specified.
Review before installing or using in production. Pin the skill source and npm dependencies, treat all transfer/wrap/unwrap snippets as real-fund operations, validate recipient, mint, amount, decimals, cluster, and serialized transaction contents before signing, and keep Privy app secrets and treasury authorization keys in server-side secret storage only. For nullifiers, use a deterministic or persisted operation identifier for retries rather than generating a fresh random ID each time.
references/nullifiers.md:39Random nullifier identifiers fail to enforce idempotency across repeated business operations
SKILL.md:72Security-sensitive dependencies are installed through mutable tags and unpinned versions
The skill instructs users to install from an unpinned remote source using npx skills add Lightprotocol/skills, which can fetch whatever content is current at execution time. If the upstream repository, package resolution, or dependency chain is compromised, users may ingest altered skill content or tooling without version integrity guarantees.
This documentation provides ready-to-use examples for transfer, wrap, and unwrap flows that directly move tokenized assets, but it does not include explicit safety guidance about validating recipient addresses, token mint, amount, network, or the irreversibility of submitted transactions. In a payments-and-wallets skill, that omission increases the chance that integrators ship unsafe UX or automation that can cause permanent user fund loss through operator error or mis-signing rather than a protocol exploit.
The Node.js example sends a wallet authorization private key to Privy as part of the signing request, which is highly sensitive signing material. Even if this is required by the provider's API, documenting and encouraging this pattern without explicit warnings, scope restrictions, or secret-handling guidance can lead developers to expose treasury signing authority in backend logs, misconfigured environments, or third-party services.
This markdown file includes examples for sending tokens, wrapping from SPL, and unwrapping to SPL, which are user-asset affecting blockchain operations. The document explains how to perform them but does not include any warning about spending funds, network fees, or the irreversibility of submitted transactions.