T09 · Insecure Skill Coding Practices
- Location
SKILL.md:723- Finding
Unsupported Git-Ignore Claim May Expose Cloud API Credentials
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This decision-support skill is not malicious, but it needs review because it handles sensitive decision records, cloud/team sync, rollback, and API key storage with weak scoping and security guidance.
Review this skill before installing in environments with confidential business, HR, client, or strategy data. Use cloud/team sync only with explicit user approval, avoid putting decision records or API keys into Git, store secrets in a real credential manager, and treat HR/personnel reports as advisory rather than authoritative.
SKILL.md:723Unsupported Git-Ignore Claim May Expose Cloud API Credentials
Code scans file system directories looking for sensitive files. This could be reconnaissance for credential theft.
EOF
ls -la ~/soul-decision/
### 300秒完整企业部署
The skill promotes cloud sync and team-sharing of decision memory without a prominent, up-front warning that sensitive decision data may be transmitted to external services. In a skill handling business, HR, and strategic content, this omission increases the risk of accidental disclosure of confidential or personal information.
Automatic snapshot creation, diffing, and restore operations can modify or revert stored decision data, yet the skill lacks a prominent warning about the risks of rollback and state mutation. In practice this can lead to accidental data loss, restoration of stale state, or unintended overwrites of decision history.
The error-handling guidance tells the agent to run ping to test connectivity even when the primary problem is missing input parameters. That expands behavior into unrelated network activity, which can violate least-privilege expectations, leak environment/network metadata, or be abused as a pretext for outbound probing.
Line L041 states '永远不替你做决定' ('never makes decisions for you'), but later examples include generating manager decision-ability reports for HR and benchmark-style assessments that can materially influence personnel decisions. While not a direct code contradiction, the documentation's intent statement is in tension with later operational guidance that supports consequential evaluative use.
The phrase '完全中文化表达,适配中文用户工作流' indicates a language-localization constraint in natural language. The document does not also state that users may choose another language or locale, so this can conflict with policies against forcing a language without opt-in.