T09 · Insecure Skill Coding Practices
- Location
SKILL.md:77- Finding
Shell Command Injection Through Unvalidated Git Parameters
- Content
View full analysis
` or `git commit -m ""`. 3. The Agent passes the generated string to a shell through its unrestricted `e ...[truncated 1115 chars]- Remediation
View remediation
`, to prevent option injection. 7. Preserve commit messages as a single opaque process argument rather than manually adding quotation marks. 8. Resolve and validate paths against the intended repository root before execution. 9. Require explicit user confirmation before `push`, branch deletion, destructive resets, forced updates, or operations affecting a remote repository. 10. Restrict execution to the intended repository directory and apply platform-level filesystem and network sandboxing. 11. Avoid returning command output that may contain credentials, authenticated remote URLs, tokens, or other sensitive environment details. ]]>
