T09 · Insecure Skill Coding Practices
- Location
SKILL.md:44- Finding
Shell Command Injection Through Unescaped User-Controlled Test and Branch Names
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill mostly matches its TestDino CI-monitoring purpose, but it asks users to grant broad shell execution and persist credentials in ways that create avoidable security risk.
Review this before installing. Use a narrowly scoped or read-only TestDino token if possible, avoid duplicating it across config files, protect any token-bearing files, and be cautious about enabling broad exec approval. Prefer pinned, reviewed package versions and avoid pasting real gateway tokens directly into shell commands.
SKILL.md:44Shell Command Injection Through Unescaped User-Controlled Test and Branch Names
scripts/install-check.sh:55Unpinned npm Package Is Downloaded and Automatically Executed
README.md:42Personal Access Token Is Duplicated Across Plaintext Configuration Files
README.md:223Gateway Authentication Token Is Exposed Through Command-Line Arguments
Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
## Requirements
- [OpenClaw](https://openclaw.dev) installed and running
- [TestDino account](https://app.testdino.com) with a Personal Access Token
- Node.js 18+
- [mcporter](https://www.npmjs.com/package/mcporter) (CLI tool for running MCP servers)
Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
### Step 1: Get your TestDino PAT
1. Log in to [app.testdino.com](https://app.testdino.com)
2. Go to **Settings → Personal Access Tokens**
3. Generate a new token and copy it
---
Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
### Step 1: Get your TestDino PAT
1. Log in to [app.testdino.com](https://app.testdino.com)
2. Go to **Settings → Personal Access Tokens**
3. Generate a new token and copy it
---
Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
### Step 1: Get your TestDino PAT
1. Log in to [app.testdino.com](https://app.testdino.com)
2. Go to **Settings → Personal Access Tokens**
3. Generate a new token and copy it
---
Persisting the PAT in a long-lived local config file creates durable credential exposure beyond a single session. If the host is compromised, backed up to cloud storage, or accessed by other local processes or users, the token can be recovered and reused to access TestDino data.
Create or edit ~/.mcporter/mcporter.json:
{
The README instructs users to place a personal access token directly into ~/.mcporter/mcporter.json in plaintext, with no warning about filesystem exposure, backups, screenshots, or accidental commits. Storing long-lived credentials unencrypted in config files increases the chance of credential theft and downstream account compromise.
The README repeats the unsafe pattern by directing users to store the same personal access token in openclaw.json plaintext entries, expanding the number of locations where the secret resides. Duplicating secrets across configs increases exposure surface and makes revocation, auditing, and safe handling harder.
Skill enumerates or reads other installed skills. Access to other skills' SKILL.md files or the skills directory reveals prompt instructions, capabilities, and secrets that should be invisible to peer skills.
Copy SKILL.md from this repo into your OpenClaw workspace skills folder:
~/.openclaw/workspace/skills/testdino/SKILL.md
Create the folder if it doesn't exist.
Skill enumerates or reads other installed skills. Access to other skills' SKILL.md files or the skills directory reveals prompt instructions, capabilities, and secrets that should be invisible to peer skills.
Copy SKILL.md from this repo into your OpenClaw workspace skills folder:
~/.openclaw/workspace/skills/testdino/SKILL.md
Create the folder if it doesn't exist.
Skill establishes unauthorized persistence across sessions via cron jobs, startup scripts, or state files. Session persistence allows an attacker to maintain access beyond the current interaction.
~/.openclaw/cron/jobs.json)Write directly to the cron store. Create or edit ~/.openclaw/cron/jobs.json:
{
The README markets the skill as read-only CI intelligence, but the documented tool surface includes state-changing operations such as creating and updating manual test cases and suites. This capability mismatch can cause users to grant broader trust and permissions than intended, increasing the risk of unauthorized or accidental modifications in TestDino.
The skill instructs use of the exec tool to run shell commands (mcporter call ...) but does not declare any explicit tool scope such as permissions or allowed-tools. That increases the attack surface because a host may expose broader shell capability than intended, and the skill text includes parameter substitution from user input into command lines, making unrestricted execution more risky in practice.
npx commands without a version suffix (e.g. @1.0.0) create a rug-pull risk if the upstream server is compromised and publishes a malicious update.
npx commands without a version suffix (e.g. @1.0.0) create a rug-pull risk if the upstream server is compromised and publishes a malicious update.
npx commands without a version suffix (e.g. @1.0.0) create a rug-pull risk if the upstream server is compromised and publishes a malicious update.
The script executes 'npx --yes testdino-mcp --version' without pinning an exact package version. That causes retrieval and execution of the latest package version from npm, which introduces supply-chain risk if the package is compromised, typosquatted, or unexpectedly changed.
Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.
echo "Validating PAT with TestDino API..."
HTTP_STATUS=$(curl -s -o /dev/null -w "%{http_code}" \
-H "Authorization: Bearer $TESTDINO_PAT" \
"https://api.testdino.com/api/mcp/hello" 2>/dev/null || echo "000")
if [ "$HTTP_STATUS" = "200" ]; then
echo " OK: PAT is valid — TestDino API responded successfully"