T09 · Insecure Skill Coding Practices
- Location
scripts/backtest_strategy.py:215- Finding
Spreadsheet Formula Injection in Generated CSV Report
- Content
View full analysis
dict[str, list[tuple[str, float]]]: signals: dict[str, list[tuple[str, float]]] = {} with path.open(newline="", encoding="utf-8") as handle: reader = csv.DictReader(handle) require_columns(reader.fieldnames, {"date", "ticker", "score"}, path) for row in reader: date = required_value(row, "date", path) ticker = required_value(row, "ticker", path) score = float(required_value(row, "score", path)) signals.setdefault(date, []).append((ticker, score)) return signals ``` ```python periods.append( { "signal_date": signal_date, "entry_date": entry_date, "exit_date": exit_date, "selected_tickers": selected, "gross_return": gross_return, "turnover": period_turnover, "cost": cost, "net_return": net_return, } ) ``` ```python for period in periods: row = dict(period) row["selected_tickers"] = ";".join(period["selected_tickers"]) writer.writerow(row) ``` ### Technical Analysis The `ticker` field is read from an externally supplied signal CSV and retained without validation or output encoding. If a malicious ticker is selected by the ranking process, its value is joined into the `selected_tickers` field and written to `backtest_periods.csv`. Values beginning with spreadsheet formula-control characters such as `=`, `+`, `-`, or `@` can be interpreted as formulas when the generated CSV is opened in spreadsheet software. CSV quoting performed by `csv.DictWriter` does not reliably neutralize formula interpretation because quoting is part of the CSV representation rather than spreadsheet-safe encoding. An attacker who can influence the signal CSV can therefore ...[truncated 1652 chars]- Remediation
View remediation
str: if not TICKER_PATTERN.fullmatch(value): raise ValueError(f"{path} contains an invalid ticker value") return value ``` 2. Apply validation immediately after reading the field: ```python ticker = validate_ticker(required_value(row, "ticker", path), path) ``` 3. As defense in depth, neutralize all attacker-controlled text immediately before CSV export. After accounting for leading whitespace, prefix cells beginning with `=`, `+`, `-`, or `@` with a single quote: ```python def spreadsheet_safe(value: str) -> str: if value.lstrip().startswith(("=", "+", "-", "@")): return "'" + value return value ``` 4. Apply output neutralization separately to every ticker before joining them: ```python row["selected_tickers"] = ";".join( spreadsheet_safe(ticker) for ticker in period["selected_tickers"] ) ``` 5. Add regression tests covering every dangerous prefix, leading whitespace, tabs, legitimate ticker formats, and multiple selected tickers. 6. Document that generated CSV files contain external input and should not be opened with spreadsheet formula execution or external-content updates enabled. ]]>
