T09 · Insecure Skill Coding Practices
- Location
scripts/sync_ima.py:120- Finding
Unrestricted File Path Allows Upload of Arbitrary Readable Files
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This memory skill is coherent in purpose, but it enables persistent storage and IMA synchronization in ways that can transmit private memory data without reliable user control.
Review this carefully before installing. Use it only if you are comfortable with conversation-derived memories being stored on disk and potentially synchronized to IMA. Do not rely on enabled=false as a sync block in the current script, avoid using --file with sensitive paths, and keep secrets, credentials, private keys, and confidential project files out of memory content.
scripts/sync_ima.py:120Unrestricted File Path Allows Upload of Arbitrary Readable Files
scripts/sync_ima.py:42Documented Synchronization Disable Flag Is Not Enforced
SKILL.md:235Installation Instructions Execute an Unpinned Registry Package
The README advertises persistent memory and says IMA knowledge-base sync is enabled by default, but it does not clearly warn users that data may be stored long-term and transmitted to an external platform. Because the skill is specifically designed to capture cross-session memories, the lack of prominent consent and disclosure materially increases the chance of privacy violations or unintended exfiltration of sensitive information.
Allowing the AI to decide on its own that information is 'worth long-term saving' delegates consent and retention decisions to an unreliable heuristic. In this skill's context, that can lead to persistent storage of secrets, personal data, or confidential project details even when the user never explicitly asked for retention.
The IMA sync feature is enabled by default and synchronizes user preferences, decisions, and project data to an external platform, yet the skill does not prominently warn that user data may leave the local environment. This significantly increases privacy and confidentiality risk because the skill handles memory content that may include personal or sensitive information.
The retrieval triggers like '我记得、之前说过' are ambiguous and can overlap with normal dialogue, causing the assistant to access persistent memory when the user may only be speaking conversationally. In this skill context, that can surface stale or sensitive stored data unexpectedly, creating privacy and context-integrity risks.
The memory-write trigger phrases such as '记住、记录、存档' are broad enough to match ordinary conversation, which can cause unintentional persistence of sensitive user content. In a memory skill, accidental writes are particularly risky because they create durable storage and may later be synchronized externally.
The README instructs users to run npx clawhub install yaoyaoya-memory without pinning a specific version. This allows execution of whatever package version is current at install time, increasing supply-chain risk if the package or one of its transitive dependencies is compromised or unexpectedly changed.
Most of the user-facing instructions, trigger phrases, labels, and examples are presented only in Chinese, which effectively constrains usage to a specific language. The file does not offer multilingual alternatives or state that the locale restriction is intentional and justified.
The skill describes writing conversation-derived information into MEMORY.md, daily logs, and learning files, but does not present a clear user-facing warning that this storage is persistent. Users may disclose information under normal chat expectations without realizing it will be retained across sessions on disk.
The memory-write trigger phrases are broad enough to overlap with ordinary conversation, so the assistant may persist data when the user did not intend durable storage. In a memory skill, accidental writes can capture sensitive personal, project, or behavioral information into local files without meaningful consent.
The skill's default behavior semantically encourages persistence and synchronization of user profile data, preferences, decisions, and project details. In context, this is more dangerous because the skill is specifically designed as a long-term memory layer, making privacy leakage and over-retention a core operational risk rather than an incidental one.
The install command references an unpinned package via npx clawhub install yaoyaoya-memory, which can fetch whatever version is current at execution time. This creates a supply-chain risk where a compromised or incompatible upstream release could be installed unexpectedly.
The notes_mapping keys are natural-language labels written only in Chinese, which suggests the skill is configured around a fixed language/locale. There is no indication in this file that users can choose another language or that the Chinese-only constraint is intentionally limited to a region-specific deployment.
This code file contains natural-language instructions and messages that enforce a specific language/locale for users. The policy allows locale constraints only when the user is given a choice or the restriction is clearly justified, which is not present here.
This code file contains user-facing natural-language instructions and examples in Chinese, and the CLI also includes Chinese note examples and prompts. Because the skill does not offer a language choice or document a justified locale restriction, it may violate a language/locale policy requiring user opt-in.