Back to skill

Security audit

Amap Poi Fetch

Security checks for vulnerabilities and agentic risk

Overview

This skill does what it advertises, but it should be reviewed because it ships a reusable Amap API key and can create Excel files from third-party data without formula safeguards.

Install only after replacing the bundled Amap key with your own restricted key, or treating the bundled key as already exposed. Prefer a pinned dependency in a virtual environment. Generated Excel files contain third-party POI text, so open them with external links and active content disabled, or use `--skip-excel` when XLSX output is not needed.

Vulnerability Patterns
  • Insecure DependenciesIntroduces malicious components through unsafe dependency sources
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
Findings (3)

T09 · Insecure Skill Coding Practices

Error
Location
scripts/poi_fetch.py:10
Finding

Hard-Coded Amap API Credential Exposed in Source Code

Content
View full analysis
Remediation
View remediation

T09 · Insecure Skill Coding Practices

Error
Location
scripts/poi_fetch.py:83
Finding

Excel Formula Injection Through Untrusted POI Fields

Content
View full analysis
Remediation
View remediation

T08 · Insecure Dependencies

Warning
Location
SKILL.md:69
Finding

Unpinned Runtime Dependency Installation

Content
View full analysis
Remediation
View remediation
\ --hash=sha256: ``` 3. Install with hash enforcement: ```bash python3 -m pip install --require-hashes -r requirements.txt ``` 4. Review and lock applicable transitive dependencies as well. 5. Use a dedicated virtual environment rather than a global or privileged Python installation. 6. Document the intended trusted package index and disable unintended extra indexes. 7. Periodically update pinned versions through a controlled review process that includes vulnerability and provenance checks. ]]>
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
  • Taint TrackingDirect Taint Flow, Variable-Mediated Taint Flow, Credential Exfiltration Chain
  • MCP Least PrivilegeUnderdeclared Capability, Wildcard Permission, Missing Permission Declaration
  • Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
Findings (8)

Tainted flow: 'url' from os.environ.get (line 44, credential/environment) → urllib.request.urlopen (network output)

Critical
Category
Data Flow
Confidence
90% confidence
Finding

Credentials or environment variables flow to a network sink. This is a high-confidence indicator of credential exfiltration.

Content

Scanner excerpt · scripts/poi_fetch.py (reported line 15)May include surrounding context.

python
SKIP_EXCEL = "--skip-excel" in sys.argv

def fetch_json(url):
    with urllib.request.urlopen(url, timeout=10) as r:
        return json.loads(r.read().decode("utf-8"))

def get_districts(city_name):

Ssd 3

High
Category
Not specified by scanner
Confidence
99% confidence
Finding

The documentation exposes a default owner API key in plaintext, which is effectively a credential disclosure. Anyone reading the skill can reuse the key for unauthorized API calls, leading to quota exhaustion, billing abuse, attribution problems, and possible service suspension for the legitimate owner.

Content

No source excerpt is available for this finding.

Undeclared Tool Scope

Medium
Category
MCP Least Privilege
Confidence
90% confidence
Finding

The skill documentation describes capabilities to access the network, read environment-provided data such as API keys, and write files locally, but it does not declare any explicit tool scope or permission boundary. That increases the risk of overbroad execution and makes it harder for users or the platform to understand and constrain what the skill is allowed to do.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
91% confidence
Finding

The trigger phrase “抓取POI” is very broad and overlaps with ordinary map, search, and data-query requests, which can cause accidental activation of a networked scraping and file-writing workflow. Unintended execution is dangerous here because the skill performs external collection and persists output locally, potentially without the user realizing a more invasive action was invoked.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
88% confidence
Finding

The skill performs remote data collection and writes JSON and Excel artifacts to the local workspace, but the documentation does not present this as an explicit consent or disclosure step to the user. This can lead to silent data acquisition and local persistence, which is risky in agent environments where users may expect a simple lookup rather than scraping plus file creation.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
97% confidence
Finding

The file's natural-language interface and usage text are entirely in Chinese, and the script prints Chinese-only runtime messages. Under the stated policy, forcing a specific language without user opt-in is a locale-policy issue unless the regional restriction is explicitly documented and justified.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Low
Category
Not specified by scanner
Confidence
71% confidence
Finding

SQP-3 适用于所有文件。文档中的描述、触发词和示例均仅以中文给出,未说明是否要求中文输入,也未提供其他语言选项或用户可选择的 locale 行为。

Content

No source excerpt is available for this finding.

Missing User Warnings

Low
Category
Not specified by scanner
Confidence
89% confidence
Finding

This code creates a directory under ~/.openclaw/workspace/data and persists fetched POI data there, later also saving an Excel export. Although there are progress prints, the initial user-facing description does not clearly warn that local files will be created and populated, which is the kind of disclosure this rule asks for on code files.

Content

No source excerpt is available for this finding.