T09 · Insecure Skill Coding Practices
- Location
scripts/phase_a_score.py:68- Finding
Configurable API endpoint can disclose the DeepSeek credential and article content
- Content
View full analysis
PhaseAConfig: api_key = os.getenv("DEEPSEEK_API_KEY", "").strip() base_url = os.getenv("DEEPSEEK_BASE_URL", "https://api.deepseek.com/v1").strip() model = os.getenv("DEEPSEEK_MODEL", "deepseek-reasoner").strip() or "deepseek-reasoner" timeout = float(os.getenv("DEEPSEEK_TIMEOUT_SECONDS", "60")) retries = int(os.getenv("DEEPSEEK_RETRY_COUNT", "2")) return PhaseAConfig( api_key=api_key, base_url=base_url, model=model, timeout=timeout, retries=max(0, retries), ) def _build_client(config: PhaseAConfig) -> Any: if not config.get("api_key"): raise RuntimeError("DEEPSEEK_API_KEY is required unless --mock is used") try: from openai import OpenAI except Exception as exc: raise RuntimeError("openai package is required for direct DeepSeek API mode") from exc return OpenAI( api_key=config["api_key"], base_url=config["base_url"], timeout=config["timeout"], ) def _call_deepseek(prompt: str, config: PhaseAConfig, client: Any) -> str: attempts = config["retries"] + 1 last_err: Optional[Exception] = None for attempt in range(1, attempts + 1): try: resp = client.chat.completions.create( model=config["model"], messages=[ {"role": "system", "content": SYSTEM}, {"role": "user", "content": prompt}, ], temperature=0, ) ``` ### Technical Analysis `DEEPSEEK_BASE_URL` is taken directly from the process environment and supplied to the OpenAI-compatible client without validating its scheme or hostname ...[truncated 1732 chars]- Remediation
View remediation
