T09 · Insecure Skill Coding Practices
- Location
scripts/clawvisual-mcp-client.mjs:248- Finding
Sensitive RPC Data Can Be Transmitted over Cleartext HTTP
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill is coherent for carousel generation, but it needs Review because it can store and transmit API keys and user content, auto-start a detached local service, and invoke broad MCP tools without enough safeguards.
Install only if you are comfortable with a global npm CLI that can start a local web/MCP service and store API keys on disk. Keep `CLAWVISUAL_MCP_URL` on localhost or HTTPS, avoid submitting sensitive or proprietary content unless the configured LLM/MCP service is approved, secure or remove `~/.clawvisual/config.json`, and treat the raw MCP call command as developer-level access.
scripts/clawvisual-mcp-client.mjs:248Sensitive RPC Data Can Be Transmitted over Cleartext HTTP
scripts/clawvisual-mcp-client.mjs:41API Keys Are Stored in Plaintext without Enforced Restrictive Permissions
SKILL.md:14Installation Instructions Use an Unpinned Global npm Package
Skill accesses MCP server configuration files (mcp.json). MCP configs contain server URLs, authentication tokens, and tool definitions — reading them allows the skill to discover and potentially abuse other tool integrations.
- `clawvisual initialize`: probe/start local service and print Web URL.
- `clawvisual status`: check service identity (must be `clawvisual-mcp`).
- `clawvisual tools`: list MCP tools.
- `clawvisual convert --input <text_or_url> [--slides auto|1-8] [--ratio 4:5|1:1|9:16|16:9] [--lang <code>]`
- `clawvisual status --job <job_id>`: query job state and result.
- `clawvisual revise --job <job_id> --instruction <text> [--intent rewrite_copy_style|regenerate_cover|regenerate_slides]`
The client can automatically spawn and detach a local Next.js development server when the MCP endpoint is unavailable. Even though it restricts auto-start to localhost and probes service identity, launching a background subprocess is a materially broader capability than a simple carousel-generation client and can surprise users, create persistence-like behavior during a session, and increase attack surface by exposing a local web service.
The skill declares no explicit tool scope or permission boundaries despite requiring environment-variable access and network-capable behavior. In an agent setting, this weakens least-privilege controls and can allow the skill to access secrets or make outbound requests without clear user-visible constraints.
The documentation instructs users to submit URLs or long-form text to an LLM-backed local service but does not warn that this content may be transmitted to an external model provider via configured API URL/key settings. Users may unknowingly send proprietary, personal, or sensitive data to third-party services, creating confidentiality and compliance risks.
The client persists configuration, including API secrets, into a predictable file under the user's home directory (~/.clawvisual/config.json). While this appears intended for convenience rather than abuse, storing secrets locally expands the skill’s effective capability beyond the stated MCP client role and increases credential exposure risk if file permissions are weak, backups are shared, or the host is multi-user.
The code writes configuration directly to ~/.clawvisual/config.json and supports storing API keys there, but does not warn users at the point of storage that credentials will persist on disk. This is dangerous because users may assume ephemeral use, then unintentionally leave reusable secrets in plaintext or broadly readable local files.
The convert command forces output_language to en-US whenever the user does not explicitly provide --lang. This imposes a specific locale by default rather than offering a neutral choice or explicit opt-in, which can violate language/locale policy requirements.
The generic call command allows invoking arbitrary MCP tool names with arbitrary JSON arguments, bypassing the narrower command surface otherwise exposed by the CLI. In this skill context, that broadens the reachable functionality to whatever the backend MCP server offers, which may include sensitive or unsafe operations not reflected in the manifest or expected by users.
The code spawns a detached Next.js dev server automatically when initialize/tools/other commands detect the service is unavailable. Although the usage text mentions auto-start for initialize, the subprocess execution affecting the local system is not consistently disclosed at the execution point for other commands that also call ensureServerReady().