Back to skill

Security audit

S2-SP-OS Universal Spatial Sensor Sniffer

Security checks for vulnerabilities and agentic risk

Overview

The skill claims to perform real IoT network discovery, but the inspected code returns hardcoded device results and tells agents to present them as real findings.

Treat this as a review-required skill. Do not rely on its scan results for security, inventory, onboarding, or automation decisions unless the publisher replaces the hardcoded demo output with verifiable discovery, labels simulations clearly, and adds explicit authorization and credential-handling guidance.

Vulnerability Patterns
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Tool Hijacking and SpoofingModifies or replaces tools so legitimate-looking calls execute attacker logic
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
  • Embedded Malicious CodeShips malicious scripts inside the skill and executes them locally
Findings (4)

T07 · Tool Hijacking and Spoofing

Error
Location
universal_scanner.py:35
Finding

Fabricated Network Discovery Results Presented as Genuine Scan Findings

Content
View full analysis
list: """ [第一战区 - S2 原生协议]: 零知识心跳捕获与边缘 TLS 握手 专门监听符合 S2 V2.0.0 规范的硬件心跳,并模拟提取 6D-VTM。 """ discovered_s2_nodes = [] # 模拟在局域网内 (UDP 49152) 捕获到了我们在网关协议中定义的那个 SMART 厂商的临时身份心跳 # 并在获得用户授权后,通过本地 TLS 1.3 提取到了 6D-VTM 宣言 discovered_s2_nodes.append({ "ip": "192.168.1.88", "protocol": "S2_Native_TLS1.3", "port": 49152, "raw_fingerprint": "S2_Wandering_Node", "status": "Awaiting_User_Approval", "s2_auth_data": { "temp_id": "HSMART260329AAB3C4D5E6", "mac_hidden": "TRUE (Edge-Local Only)" }, "s2_6d_vtm_payload": { "1_product_name": "Smart Temp Sensor Pro", "2_product_category": "Environmental Sensor", "3_vendor_full_name": "RobotZero Hardware Dept", "4_vendor_website": "https://space2.world/developer", "5_quality_certs": ["ISO9001"], "6_specific_licenses": ["S2-Class-A"] } }) return discovered_s2_nodes def _active_sniffing_legacy(self) -> list: """ [第二战区 - 传统协议]: 极速主动嗅探 (Legacy Active Sniffing) 向下兼容传统的 Modbus / MQTT 协议。 """ discovered = [] discovered.append({ "ip": "192.168.1.100", "protocol": "Modbus_TCP", "port": 502, "raw_fingerprint": "GH-506_Outdoor_Weather_Station", "status": "Active" }) return discovered ``` ### Technical Analysis The methods advertised as native heartbeat sniffing and legacy active network discovery do not perform socket operations, packet capture, TLS negotiation, port probing, or protocol identification. They unconditionally return fixed records for `192.168.1.88` and `192.168.1.100`. Although the constructor stores the user-supp ...[truncated 1682 chars]
Remediation
View remediation

T07 · Tool Hijacking and Spoofing

Warning
Location
universal_scanner.py:85
Finding

Environment Variable Presence Spoofs Successful Gateway Registry Verification

Content
View full analysis
list: """ [第三战区]: 休眠节点对账 (Sleeping Node Bypass) """ ha_token = os.environ.get("S2_HA_TOKEN") sleeping_nodes = [] if ha_token: sleeping_nodes.append({ "source": "Home_Assistant_Registry", "protocol": "Zigbee_3.0", "device_type": "PIR_Motion_Sensor", "name": "Aqara_Motion_T1", "status": "Sleeping_Low_Power" }) return sleeping_nodes ``` The result later reports: ```python "cross_verification_used": True if os.environ.get("S2_HA_TOKEN") else False, ``` ### Technical Analysis The gateway verification routine checks only whether `S2_HA_TOKEN` contains a nonempty value. It does not contact a Home Assistant instance, validate the token, request a registry, authenticate a response, or verify any device record. Any arbitrary value therefore causes the scanner to: - Insert a fixed sleeping-node record. - Attribute that record to `Home_Assistant_Registry`. - Report `cross_verification_used` as true. This conflates token presence with successful authentication and verification. The resulting output appears to represent trusted gateway data even though no gateway interaction occurred. ### Attack Path 1. A user, wrapper script, or process sets `S2_HA_TOKEN` to any nonempty string, including an invalid token. 2. The scanner checks only for the variable's presence. 3. A predetermined Aqara motion sensor record is added to the inventory. 4. The output reports that gateway cross-verification was used. 5. Downstream users or agents accept the fixed record as authenticated gateway registry data. An attacker able to influence the process environment could trigger this false verification, but no special token knowledge is ...[truncated 622 chars]
Remediation
View remediation

T07 · Tool Hijacking and Spoofing

Warning
Location
universal_scanner.py:143
Finding

Unsupported Discovery and Zero-Exfiltration Compliance Claims

Content
View full analysis
Remediation
View remediation

T01 · Skill Instruction Hijacking

Warning
Location
s2-universal-scanner-AGENT-EXAMPLES.md:21
Finding

Agent Instructions Encourage Unsupported Claims of Device Verification and Integration

Content
View full analysis
Remediation
View remediation
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Excessive AgencyUnrestricted Tool Access, Autonomous Decision Making, Scope Creep
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
  • MCP Least PrivilegeUnderdeclared Capability, Wildcard Permission, Missing Permission Declaration
  • MCP Tool PoisoningHidden Instructions, Unicode Deception, Parameter Description Injection
Findings (15)

Tp4

High
Category
MCP Tool Poisoning
Confidence
97% confidence
Finding

The skill advertises active LAN scanning, protocol probing, and gateway cross-verification, but the described behavior is reportedly simulated and does not implement the claimed network actions. This is dangerous because operators or downstream agents may make security, inventory, or privacy decisions based on false assurance that a real scan occurred, and the inflated claims around 'zero-trust' and privacy-safe extraction can mislead reviewers about the tool’s actual trust boundary.

Content

No source excerpt is available for this finding.

Missing User Warnings

High
Category
Not specified by scanner
Confidence
94% confidence
Finding

The skill describes active LAN scanning and secret gateway-registry pulling but does not present a clear user-facing warning about the network, privacy, and authorization implications. In this context, the combination of scanning plus inventory correlation is more dangerous because it can reveal hidden or offline devices and may cross expected privacy boundaries without informed consent.

Content

No source excerpt is available for this finding.

Lp1

High
Category
MCP Least Privilege
Confidence
82% confidence
Finding

The code imports socket and requests and advertises LAN scanning and gateway verification, indicating network capability, but the declared permissions do not cover network use. Even though this sample currently returns mock data, undeclared network capability in a security-sensitive scanner skill increases the risk of future unauthorized probing or outbound requests without appropriate review.

Content

No source excerpt is available for this finding.

Lp1

High
Category
MCP Least Privilege
Confidence
82% confidence
Finding

The code imports socket and requests and advertises LAN scanning and gateway verification, indicating network capability, but the declared permissions do not cover network use. Even though this sample currently returns mock data, undeclared network capability in a security-sensitive scanner skill increases the risk of future unauthorized probing or outbound requests without appropriate review.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
90% confidence
Finding

The metadata declares sensitive environment variables, including a home-automation token, without explaining credential handling, storage, scope, or redaction expectations. This is risky because agents or users may expose tokens in logs, prompts, shell history, or overly broad execution contexts while believing the skill handles them safely.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
83% confidence
Finding

The skill frames itself as an 'ultimate' universal scanner and provides direct execution instructions without clear scope limits, authorization requirements, or environmental constraints. In a security-sensitive context, vague activation language can cause agents or users to run intrusive discovery actions on networks where they lack permission, increasing the chance of unauthorized reconnaissance.

Content

No source excerpt is available for this finding.

Context-Inappropriate Capability

Medium
Category
Not specified by scanner
Confidence
88% confidence
Finding

The 'sleeping node' feature expands from LAN discovery into pulling gateway registries using a token, which is a broader and more sensitive capability than simple subnet scanning. That increases exposure to device inventory, configuration, and potentially privacy-sensitive metadata beyond what users may expect from a scanner skill.

Content

No source excerpt is available for this finding.

Intent-Code Divergence

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The examples establish a safety rule that native devices must not be onboarded automatically, then later normalize automatic integration of a legacy device into control logic without any approval step. In an IoT scanning skill, this can cause unauthorized enrollment of devices and unintended automation changes, blurring the boundary between discovery and actuation.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
97% confidence
Finding

The example agent responses are written as direct user-facing output in Chinese (for example, addressing the user as '主人') with no indication that language selection is optional. This creates a natural-language policy concern because the skill appears to prescribe a specific language/locale without user opt-in or documented justification.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
92% confidence
Finding

The example describes the agent automatically decomposing a discovered Modbus device, wiring its outputs into system logic, and changing HVAC behavior without any warning or consent step. Documentation that encourages silent system-impacting actions is dangerous because downstream agent implementations may treat these examples as authorization to perform live control changes after passive scanning.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
96% confidence
Finding

The second scenario again provides the agent's response exclusively in Chinese as the expected user-facing behavior, with no alternative language path or opt-in. Repeating a fixed-language output pattern suggests the skill enforces a locale preference rather than adapting to the user's language.

Content

No source excerpt is available for this finding.

Ae4

Medium
Category
analysis-evasion
Confidence
80% confidence
Finding

Suspicious Unicode normalization or mixed-script content

Content

No source excerpt is available for this finding.

Description-Behavior Mismatch

Medium
Category
Not specified by scanner
Confidence
98% confidence
Finding

The skill claims to perform LAN scanning and gateway API cross-verification, but the implementation fabricates device discoveries with hard-coded results instead of performing the stated actions. In a security or asset-discovery context, fabricated results are dangerous because users may make trust, inventory, or incident-response decisions based on false evidence.

Content

No source excerpt is available for this finding.

Intent-Code Divergence

Medium
Category
Not specified by scanner
Confidence
98% confidence
Finding

The comments and output assert that heartbeats were captured, verified, and that discovery completed with zero exfiltration, but the code only emits fabricated inventory data. False attestation in tool output is especially dangerous in a scanner because it can mislead operators into believing collection and verification succeeded when no such evidence exists.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Low
Category
Not specified by scanner
Confidence
74% confidence
Finding

The skill consistently presents content in both English and Chinese, which imposes a locale/language choice in the natural-language interface without stating that the user can choose their preferred language. This may conflict with organizational language policy where locale selection should be user-driven or explicitly documented.

Content

No source excerpt is available for this finding.