T09 · Insecure Skill Coding Practices
- Location
scripts/seats_client.py:42- Finding
API Credential May Be Disclosed Through Cross-Origin HTTP Redirects
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill mostly matches its stated purpose, but review is warranted because its Seats.aero API key could be exposed if an authenticated request is redirected off-site.
Install only if you are comfortable giving the skill a Seats.aero API key and letting it persist local watcher state. Prefer running it with a scoped API key, avoid untrusted state/config paths, back up watcher configuration before using replacement options, and consider fixing redirect handling before production use.
scripts/seats_client.py:42API Credential May Be Disclosed Through Cross-Origin HTTP Redirects
The documented purpose emphasizes passive monitoring and alerting, but the skill also includes administrative functions that modify persisted watcher configuration and date ranges, including bulk updates. This mismatch can mislead operators and agents into granting or invoking the skill in contexts where write-capable maintenance actions were not expected, creating integrity and change-management risk.
The skill advertises and demonstrates capabilities to read environment variables, write/read local files, and make network requests, but it declares no explicit tool scope or permission boundary. In an agent ecosystem, this weakens least-privilege controls and can allow the skill to be invoked with broader access than its documented purpose requires, increasing the blast radius if the skill is misused or modified.
Skill enables autonomous high-impact decisions without human-in-the-loop verification. Critical operations (destructive commands, financial transactions, data deletion) should require explicit user confirmation.
--state-backend json --state-json /path/to/monitor.json \
--origin PVG --start 2026-08-01 --end 2026-08-15
# Skip confirmation prompt
python3 <skill-dir>/scripts/update_watcher_dates.py \
--origin PVG --start 2026-08-01 --end 2026-08-15 --yes
Skill enables autonomous high-impact decisions without human-in-the-loop verification. Critical operations (destructive commands, financial transactions, data deletion) should require explicit user confirmation.
--state-backend json --state-json /path/to/monitor.json \
--origin PVG --start 2026-08-01 --end 2026-08-15
# Skip confirmation prompt
python3 <skill-dir>/scripts/update_watcher_dates.py \
--origin PVG --start 2026-08-01 --end 2026-08-15 --yes
This Python file contains natural-language comments and, more importantly, user-facing alert messages in Chinese, such as the strings assembled in build_alert_message. The skill does not offer any user opt-in or locale selection, so it imposes a specific language on users, which matches the language/locale policy violation criteria.
The manifest describes monitoring award availability and persisting idempotent watcher state, which implies storing runtime state about checks and alerts. However, this script also supports administrative mutation of the watcher configuration set itself via --watchers-import and optional full replacement of existing DB watchers, which is broader than persisting state and changes the configured monitoring scope.
In this code file, setting replace=True causes an unconditional DELETE FROM watchers, which is a destructive operation affecting persisted user data. There is no confirmation prompt, visible warning, or explanatory comment/docstring near the operation to disclose that all watcher records will be removed.
When replace=True, the JSON-backed store resets self.data["watchers"] to an empty object before saving, which removes previously stored watcher configuration data. The code does not provide any confirmation, warning, or nearby disclosure that this mode overwrites existing persisted data.
The client hard-codes an "Accept-Language: en-US,en;q=0.9" header, which imposes a specific language/locale preference in requests. This is a natural-language policy concern because the file provides no user opt-in or explanation that the integration is intentionally US-English specific.