Security audit
Security checks for vulnerabilities and agentic risk
This weather skill is coherent and purpose-aligned, though users should understand that forecast lookups send the requested coordinates and API token to Caiyun's weather service.
Before installing, be comfortable providing a Caiyun Weather API token and sending requested forecast coordinates to Caiyun. Prefer coarse coordinates when exact location is unnecessary, and store the token only in the documented environment variable or config file.
The script makes outbound network requests to api.caiyunapp.com, and that capability is not covered by declared permissions. Even though network access is expected for a weather skill, undeclared external connectivity is still a security issue because it allows data transmission outside the host system without explicit user/platform approval.
The script makes outbound network requests to api.caiyunapp.com, and that capability is not covered by declared permissions. Even though network access is expected for a weather skill, undeclared external connectivity is still a security issue because it allows data transmission outside the host system without explicit user/platform approval.
The skill description includes very broad trigger phrases such as general weather, rain, temperature trend, and future weather requests, which can cause the skill to be invoked for many common prompts without clearly stating boundaries or selection criteria. Over-broad activation increases the chance of unnecessary tool use and unintended disclosure of user-supplied location data to the external weather API.
The documentation tells the agent to resolve coordinates and query the Caiyun Weather API, but it does not disclose that user location data will be transmitted to a third-party service. This creates a privacy risk because users may provide precise coordinates or place names without being informed that this data leaves the local environment.
Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.
import urllib.request
import urllib.error
API_BASE = "https://api.caiyunapp.com/v2.6"
SKYCON_EN = {
"CLEAR_DAY": "Clear", "CLEAR_NIGHT": "Clear",
Skill establishes unauthorized persistence across sessions via cron jobs, startup scripts, or state files. Session persistence allows an attacker to maintain access beyond the current interaction.
token = get_token()
if not token:
print(json.dumps({"error": "No API token found. Set CAIYUN_TOKEN env var or create ~/.config/knowair/token"}))
sys.exit(2)
if args.forecast_type == "hourly":
The example mixes English-language usage with one example that explicitly forces Chinese via --lang zh and Chinese response instructions. This can violate a language/locale policy if the skill is expected to respect the user's current language unless they explicitly opt in to a different locale.
Line L180 limits the --lang option to en or zh, which is a natural-language locale constraint. The file does not document a region-specific justification or offer a broader user choice, so this is a language/locale policy concern under the stated rules.
No suspicious patterns detected.