Back to skill

Security audit

Currency Convert

Security checks for vulnerabilities and agentic risk

Overview

This currency-conversion skill appears purpose-aligned, but its exec-based command pattern and broad activation triggers create real review-worthy risk before installation.

Review before installing. The skill is not backed by evidence of theft or destructive behavior, but it should be tightened to validate currency codes and amounts before exec, use a structured no-shell process call where possible, narrow its triggers to explicit currency-conversion requests, and disclose that Open Exchange Rates receives the API key and requested currency symbols.

Vulnerability Patterns
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
  • Embedded Malicious CodeShips malicious scripts inside the skill and executes them locally
Findings (1)

T09 · Insecure Skill Coding Practices

Error
Location
SKILL.md:26
Finding

Unquoted User-Controlled Values in Exec Command Template

Content
View full analysis
Remediation
View remediation
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Excessive AgencyUnrestricted Tool Access, Autonomous Decision Making, Scope Creep
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
  • Taint TrackingDirect Taint Flow, Variable-Mediated Taint Flow, Credential Exfiltration Chain
  • MCP Least PrivilegeUnderdeclared Capability, Wildcard Permission, Missing Permission Declaration
Findings (6)

Tainted flow: 'url' from os.environ.get (line 33, credential/environment) → urllib.request.urlopen (network output)

Critical
Category
Data Flow
Confidence
90% confidence
Finding

Credentials or environment variables flow to a network sink. This is a high-confidence indicator of credential exfiltration.

Content

Scanner excerpt · convert.py (reported line 36)May include surrounding context.

python
url = f"https://openexchangerates.org/api/latest.json?app_id={app_id}&symbols={from_currency},{to_currency}"

try:
        with urllib.request.urlopen(url, timeout = 10) as response:
                data = json.loads(response.read().decode())

except urllib.error.HTTPError as e:

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
94% confidence
Finding

The README describes live exchange-rate fetching but does not clearly disclose that use of the skill results in outbound requests to Open Exchange Rates, which may transmit user-supplied currency queries and metadata to a third-party service. Missing disclosure can lead to privacy, compliance, and trust issues, especially in environments where users expect local-only processing unless told otherwise.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
89% confidence
Finding

The README encourages invocation through broad natural-language prompts such as 'Just ask naturally,' which can cause the skill to be selected in situations broader than strict currency conversion intent. In an agent environment with tool execution, overly permissive invocation guidance raises the chance of accidental execution and unintended transmission of user-provided content to the local script and external rate service.

Content

No source excerpt is available for this finding.

Undeclared Tool Scope

Medium
Category
MCP Least Privilege
Confidence
95% confidence
Finding

The skill invokes a local Python script that uses environment-provided API credentials and performs live network access, but the manifest does not declare any explicit tool scope such as allowed tools or permissions. This creates a least-privilege and governance gap: an agent runtime may permit broader execution than intended, making it harder to audit or constrain exec, environment, and network behavior safely.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
94% confidence
Finding

The trigger phrases are broad natural-language fragments such as 'how much is' and 'what is the rate', which are likely to match ordinary conversation unrelated to currency conversion. Because this skill always directs the agent to use exec and a live network-backed script, overbroad activation can cause unintended tool execution, unnecessary credential use, and expansion of the attack surface from benign user prompts.

Content

No source excerpt is available for this finding.

Context-Inappropriate Capability

Low
Category
Not specified by scanner
Confidence
77% confidence
Finding

The manifest describes a currency conversion skill using live exchange rates, but does not mention handling credentials or environment-based secret access. Reading OXR_APP_ID is not itself malicious, but secret access is a capability beyond the user-facing conversion purpose and is worth disclosing explicitly if intended.

Content

No source excerpt is available for this finding.