T09 · Insecure Skill Coding Practices
Error
- Location
scripts/gateway-create.sh:4- Finding
Persistent Command Injection Through Unvalidated Port Input
- Content
View full analysis
/dev/null 2>&1; then echo "Port $PORT is already occupied" exit 1 fi ``` ```bash # 4. Modify the port if [ -f "$CONFIG_DIR/openclaw.json" ]; then cat "$CONFIG_DIR/openclaw.json" | jq ".gateway.port = $PORT" > "$CONFIG_DIR/openclaw.json.tmp" && mv "$CONFIG_DIR/openclaw.json.tmp" "$CONFIG_DIR/openclaw.json" fi ``` ```bash # 6. Create LaunchAgent plist cat > "$PLIST_FILE" << PLISTEOF Label ai.openclaw.gateway-$INSTANCE_NAME Comment OpenClaw Gateway - $INSTANCE_NAME (port $PORT) RunAtLoad KeepAlive ThrottleInterval 1 Umask 63 ProgramArguments $NODE_PATH -e require('child_process').execSync('openclaw gateway --port $PORT', {cwd: '$CONFIG_DIR', stdio: 'inherit', env: {...process.env, OPENCLAW_HOME: '$CONFIG_DIR'}}) StandardOutPath $CONFIG_DIR/logs/gateway.log StandardErrorPath $CONFIG_DIR/logs/gateway.err.log EnvironmentVariables HOME $HOME OPENCLAW_HOME $CONFIG_DIR OPENCLAW_GATEWAY_PORT $PORT ...[truncated 2287 chars]- Remediation
View remediation
65535 )); then echo "Invalid port: expected an integer from 1 to 65535" >&2 exit 1 fi ``` 2. Restrict instance names to a conservative allowlist: ```bash if ! [[ "$INSTANCE_NAME" =~ ^[A-Za-z0-9_-]+$ ]]; then echo "Invalid instance name" >&2 exit 1 fi ``` 3. Do not invoke OpenClaw through Node `execSync()` or another shell. Put the executable and each argument into separate `ProgramArguments` entries: ```xml ProgramArguments /absolute/path/to/openclaw gateway --port 18899 ``` 4. Resolve the absolute path of the real `openclaw` executable and reject unexpected or writable replacements. 5. Generate plist files with an XML-aware mechanism rather than unescaped heredoc interpolation. 6. Validate the plist with `plutil -lint` before loading it. 7. Make auto-start an explicit opt-in operation. Creation should not silently imply persistent startup unless the user specifically requests it. ]]>