T09 · Insecure Skill Coding Practices
- Location
scripts/main.py:76- Finding
Configurable API endpoint can disclose bank-card images and API credentials
- Content
View full analysis
Vulnerability Details
File Location:
scripts/main.py:76-110
Vulnerability Type: Unrestricted sensitive-data transmission endpoint
Risk Level: HighVulnerable Code
python config.setdefault('SCNET_API_BASE', 'https://api.scnet.cn/api/llm/v1') return config def recognize_with_retry(ocr_type, file_path, config, retry_count=0): """ 带重试机制的 OCR 识别函数。 当遇到 429 (Too Many Requests) 时,自动等待后重试。 调用 Scnet OCR API 进行识别""" api_base = config['SCNET_API_BASE'] api_key = config['SCNET_API_KEY'] url = f"{api_base}/ocr/recognize" # 检查文件是否存在 if not os.path.isfile(file_path): sys.exit(f"错误: 文件不存在 - {file_path}") # 自动检测 MIME 类型 mime_type, _ = mimetypes.guess_type(file_path) if mime_type is None: mime_type = 'application/octet-stream' headers = { 'Authorization': f'Bearer {api_key}' } try: with open(file_path, 'rb') as f: files = { 'file': (os.path.basename(file_path), f, mime_type) } data = { 'ocrType': ocr_type, 'channelTag': "scnetSkills" } response = requests.post(url, headers=headers, data=data, files=files, timeout=60)Technical Analysis
The Skill must transmit a bank-card image to a remote OCR service to perform its declared function, and this transmission is disclosed in
SKILL.md. However, the destination is taken directly from the configurableSCNET_API_BASEvalue without validating its scheme or hostname.The resulting request contains two sensitive assets:
- The Scnet API credential in the
Authorizationheader. - The complete user-selected file in a multipart upload.
If the configuration contains an attacker-controlled URL, the script sends those assets to that server. It also permits a plaintext
http://base URL, which could expose the request ...[truncated 1331 chars]- The Scnet API credential in the
- Remediation
View remediation
Remediation Suggestions
- Remove endpoint configurability if custom deployments are not required, and use the documented constant:
python API_URL = "https://api.scnet.cn/api/llm/v1/ocr/recognize" - If configurability is required, parse the URL with
urllib.parse.urlparseand enforce:- Scheme exactly equal to
https. - Hostname exactly equal to
api.scnet.cn, or an explicit administrator-maintained allowlist. - An expected port and path prefix.
- No embedded username or password.
- Scheme exactly equal to
- Reject malformed URLs, plaintext HTTP endpoints, IP literals, loopback addresses, and unapproved internal or external hosts.
- Disable redirects with
allow_redirects=Falseunless they are required by the documented API. If redirects are required, validate every redirect destination before resending sensitive content. - Display the validated destination and obtain explicit user consent before uploading a bank-card image.
- Use a narrowly scoped API token and support token revocation and rotation in case configuration tampering is detected.
- Remove endpoint configurability if custom deployments are not required, and use the documented constant:
