T09 · Insecure Skill Coding Practices
- Location
scripts/generate-tts.sh:19- Finding
Arbitrary Python Code Injection Through Shell Argument Interpolation
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill is coherent for creating narrated videos, but its bundled TTS script has a real command/code injection risk and sends narration text to an external TTS service.
Install only if you trust the local inputs passed to the scripts and are comfortable reviewing or fixing the TTS script first. Avoid using sensitive screen-recording content with the remote TTS path unless disclosure is acceptable, run dependencies in a virtual environment, and avoid output paths where silent overwrite would matter.
scripts/generate-tts.sh:19Arbitrary Python Code Injection Through Shell Argument Interpolation
SKILL.md:91Unpinned Third-Party Dependency Installation
The declared description presents a full workflow for turning a silent screen recording into a narrated video, including video analysis, script writing, speech synthesis, and video/audio muxing. The supplied code chunk implements only one sub-step of that workflow: converting prewritten text segments from JSON into MP3 files and concatenating them. While Edge neural TTS use is consistent with the description, the code does not process video, inspect frames, create scripts, or output a narrated video. This is therefore a material description-to-behavior mismatch for the supplied code chunk.
Tool calls are chained to bypass individual safety checks or escalate capabilities beyond what any single tool call would allow.
echo "file 'silence.mp3'" >> "$CONCAT_FILE"
done
# Remove trailing silence entry
sed -i.bak '$ d' "$CONCAT_FILE" && rm -f "${CONCAT_FILE}.bak"
# Concatenate
ffmpeg -y -f concat -safe 0 -i "$CONCAT_FILE" -c:a libmp3lame -q:a 2 \
The script sends narration text to Microsoft Edge TTS via the edge_tts library, which means potentially sensitive on-screen-derived content leaves the local environment. In a video narration skill, this is contextually important because screen recordings may contain confidential business data, credentials, or personal information, and the script provides no explicit warning, consent gate, or offline fallback at the point of transmission.
The script invokes ffmpeg with the -y flag, which forces overwriting of the output file without prompting. If the caller supplies an existing output path, or if the default generated name already exists, prior data can be silently destroyed. In this skill context the issue is operational rather than code-execution related, but it can still cause unintended loss of user files or artifacts.
The script defaults to the voice value en-US-GuyNeural, which imposes a specific language/locale choice unless the caller overrides it manually. The file does not indicate that this locale default is optional by policy, offer an explicit language choice, or justify the locale restriction as region-specific.