Back to skill

Security audit

skill-self-improve

Security checks for vulnerabilities and agentic risk

Overview

This skill is not clearly malicious, but it can bulk-modify other skills and store user behavior/preferences without enough guardrails.

Install only if you intentionally want a tool that modifies other installed WorkBuddy skills. Review the hardcoded target list first, keep backups of affected SKILL.md files, treat learned_patterns.json as potentially sensitive, avoid storing secrets or personal data in notes/preferences, and require human review before applying any suggested SKILL.md changes.

Vulnerability Patterns
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
  • Embedded Malicious CodeShips malicious scripts inside the skill and executes them locally
Findings (2)

T02 · Agent Memory Poisoning

Warning
Location
scripts/learner.py:85
Finding

Persistent behavioral influence through unvalidated learning data

Content
View full analysis
Remediation
View remediation

T09 · Insecure Skill Coding Practices

Note
Location
scripts/learner.py:61
Finding

Potentially sensitive preferences and notes stored in plaintext

Content
View full analysis
Remediation
View remediation
Vulnerability Patterns
  • Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Excessive AgencyUnrestricted Tool Access, Autonomous Decision Making, Scope Creep
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
  • Behavioral ASTexec() Call, eval() Call, Dynamic Import
Findings (14)

Tp4

High
Category
MCP Tool Poisoning
Confidence
96% confidence
Finding

声明的核心卖点是“给任意技能注入自进化学习系统”的安装/注入器,一键完成模块复制、记忆文件初始化和 SKILL.md 修改;但提供的代码只是学习子模块本身(记录、偏好、洞察、复盘建议),并非注入器。虽然代码与“记录使用成败、偏好、自动复盘并给出改进建议”这部分描述一致,但缺少声明中最关键的注入与批量改造行为,因此描述对实际代码能力有明显夸大,构成不匹配。

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
94% confidence
Finding

The documentation does not clearly warn users that the skill may modify other skills' files and persist preference/history data. Without explicit notice and consent, users may unknowingly allow cross-skill file changes or ongoing storage of behavioral data, which creates privacy and integrity risks.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
93% confidence
Finding

The trigger phrases are broad enough that the skill may activate in unintended contexts, increasing the chance it runs file-modifying or persistence-related workflows when the user did not explicitly request them. In a skill that claims to inject code/files into other skills and store learning data, accidental invocation expands the attack surface and risks unauthorized modification or data retention.

Content

No source excerpt is available for this finding.

Ssd 3

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The skill explicitly encourages persistent collection and reuse of user preferences, usage outcomes, and error patterns across sessions. Storing this data without minimization, consent, retention limits, or access controls can expose sensitive behavioral information and create a durable privacy risk if the file is accessed by other tools, users, or processes.

Content

No source excerpt is available for this finding.

Ssd 3

Medium
Category
Not specified by scanner
Confidence
97% confidence
Finding

The schema and examples normalize writing user-derived notes, error descriptions, and preferences into a persistent JSON file. Because free-form notes may contain personal or sensitive information, this design can lead to unbounded retention of private data and secondary exposure through logs, backups, or later processing by other components.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The script copies learner.py into multiple skill directories without disclosure or integrity verification at the point of modification. In this context, adding executable code to many installed skills expands the attack surface and creates a persistence mechanism across skills, especially because the skill's stated purpose is self-improvement and cross-skill injection.

Content

No source excerpt is available for this finding.

subprocess module call

Medium
Category
Dangerous Code Execution
Confidence
70% confidence
Finding

subprocess module calls execute external commands. Without careful input validation, this enables command injection.

Content

Scanner excerpt · scripts/inject_self_improve.py (reported line 50)May include surrounding context.

python
shutil.copyfile(LEARNER_SRC, os.path.join(scripts, "learner.py"))
    # 3) 初始化 learned_patterns.json
    import subprocess
    r = subprocess.run([PY, os.path.join(scripts, "learner.py"), "init", d],
                       capture_output=True, text=True)
    # 4) 追加章节
    section = open(SECTION_SRC, encoding="utf-8").read()

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
93% confidence
Finding

The script silently appends content to each target skill's SKILL.md without any per-skill confirmation, dry-run output, or backup. In a skill ecosystem, modifying instruction files changes agent behavior and trust boundaries, so undisclosed bulk edits can introduce unexpected capabilities or persistence that operators may not notice.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The module docstring, CLI description, usage comments, and all user-facing status messages are written only in Chinese. For a general-purpose "通用" learning module intended for any WorkBuddy skill, this imposes a specific language/locale on users without opt-in or a documented regional justification.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
96% confidence
Finding

The skill explicitly documents persistent storage of operation counts, capability usage frequency, error patterns, user preferences, and improvement suggestions in a local JSON file, but provides no notice, consent flow, retention limit, or guidance on handling potentially sensitive content. This creates a privacy and profiling risk because user behavior and preferences can accumulate across sessions and may later influence outputs or be exposed to other users/processes with access to the skill directory.

Content

No source excerpt is available for this finding.

Ssd 3

Medium
Category
Not specified by scanner
Confidence
97% confidence
Finding

The section instructs persistent collection of user preferences and usage/error details into a memory file for later reuse and reflection. Because notes and error descriptions may contain user-supplied or operationally sensitive data, this creates a retention surface that can leak personal information, internal workflows, or sensitive prompts if the file is accessed, shared, or reused improperly.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The instructions tell operators to persist user preferences for future automatic reuse, including an example that sets output language, without warning that this preference will survive across sessions and alter later behavior. Silent persistence of preferences can surprise users, embed stale or sensitive assumptions, and cause unauthorized cross-session personalization.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
86% confidence
Finding

The example explicitly stores '输出语言' with value '中文' for direct future use, and the surrounding document is written as if Chinese is the default operating language. SQP-3 applies to language policy violations when a specific language is imposed without opt-in or a documented regional justification.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Low
Category
Not specified by scanner
Confidence
77% confidence
Finding

The example command records a language preference as “输出语言 --val 中文”, and the document overall is presented only in Chinese while describing behavior that remembers user preferences. This suggests a default language constraint without stating that users may choose another language or opt in to locale-specific behavior.

Content

No source excerpt is available for this finding.