T09 · Insecure Skill Coding Practices
- Location
SKILL.md:197- Finding
Shell Command Injection Through Untrusted URL and File-Path Interpolation
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This personal knowledge-base skill is purpose-aligned overall, but it needs review because it persistently indexes private knowledge, searches it proactively across broad conversations, and gives unsafe shell-command templates for user-supplied URLs and paths.
Install only if you are comfortable with the agent maintaining a persistent local knowledge index and searching saved material proactively. Prefer explicit recall commands, review what is stored in memory, avoid importing untrusted directory names or filenames, and harden the shell-command steps before using URLs, paths, or category names from untrusted sources.
SKILL.md:197Shell Command Injection Through Untrusted URL and File-Path Interpolation
SKILL.md:24Persistent Agent Context Can Be Poisoned by Knowledge-Base Metadata
The skill instructs the agent to check and use the knowledge base whenever a user asks about almost any topic, framing it as an extension of memory and saying "when in doubt, check the knowledge base." That creates overbroad activation and retrieval behavior, which can cause unintended access to prior stored content, privacy leakage, and context contamination even when the user did not ask for knowledge-base recall.
The example triggers include generic phrases such as "save this" and broad everyday requests that may appear in many unrelated conversations. This increases the chance of accidental skill activation, causing unintended file operations, memory updates, or background knowledge capture/search behavior without sufficiently clear user intent.
No suspicious patterns detected.