Back to skill

Security audit

往事漫画 · 故事连环画生成器

Security checks for vulnerabilities and agentic risk

Overview

This comic-making skill is mostly coherent, but its bundled compression script can delete unrelated files if pointed at an existing destination folder.

Review before installing. Use the compression script only with a newly created, dedicated output folder such as comic_publish, avoid pointing it at a project root or documents folder, and escape or sanitize story text before publishing generated HTML from untrusted input. Expect the default workflow and template to be Chinese-language oriented and to load Google Fonts unless modified.

Vulnerability Patterns
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
  • Embedded Malicious CodeShips malicious scripts inside the skill and executes them locally
Findings (3)

T09 · Insecure Skill Coding Practices

Warning
Location
templates/compress.py:120
Finding

Destructive Cleanup of an Unvalidated Existing Destination Directory

Content
View full analysis
Remediation
View remediation

T09 · Insecure Skill Coding Practices

Warning
Location
templates/comic_template.html:284
Finding

Generated Comic Content Is Inserted into HTML Without an Escaping Requirement

Content
View full analysis
第X集

[集标题]

[画面描述]
[旁白文字]
[画面描述]
[对白文字]
[画面描述]
[心理活动文字]
[画面描述]
[对白文字]
[旁白文字]

[结尾文字]

—— 全 书 完 ——
``` ### Technical Analysis The workflow places story-derived titles, dialogue, narration, internal thoughts, endings, and image descriptions into raw HTML placeholders. Neither the template nor the Skill instructions require HTML escaping or sanitization before substitution. Text-node placeholders can terminate their surrounding element and introduce arbitrary markup. The `alt` attribute is also an attribute context, so unescaped quotation marks can terminate the attribute and add event handlers or other attributes. For example, attacker-controlled dialogue containing a closing tag followed by an executable element could become activ ...[truncated 1328 chars]
Remediation
View remediation
`. 3. Escape attribute values by additionally encoding quotation marks and apostrophes. 4. Use a template engine with automatic escaping instead of direct placeholder replacement or string concatenation. 5. Do not permit user-controlled values to determine tag names, attribute names, or raw HTML fragments. 6. If limited formatting is required, sanitize it with a strict allowlist that excludes scripts, event-handler attributes, embedded frames, and unsafe URLs. 7. Add a restrictive Content Security Policy, for example one that disallows inline scripts and limits image, style, and font sources to approved locations. 8. Add tests using payloads in titles, dialogue, narration, endings, and `alt` text to verify that they render literally rather than becoming markup. ]]>

other

Note
Location
templates/comic_template.html:8
Finding

Comic Template Makes an Undeclared Runtime Request to Google Fonts

Content
View full analysis
Remediation
View remediation
Vulnerability Patterns
  • Privilege EscalationExcessive Permissions, Sudo/Root Execution, Credential Access
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
  • MCP Least PrivilegeUnderdeclared Capability, Wildcard Permission, Missing Permission Declaration
  • Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
Findings (5)

Undeclared Tool Scope

Medium
Category
MCP Least Privilege
Confidence
70% confidence
Finding

Without declared permissions the skill's intent is opaque and cannot be validated.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
95% confidence
Finding

The manifest description is written as producing comics from text content and explicitly targets Chinese trigger phrases such as “把我的故事做成漫画” and “生成连环画,” while the workflow later hard-codes Chinese text artifacts like 剧本.md and Chinese dialogue limits. This indicates a language-specific constraint without user opt-in or a documented regional/compliance justification, which matches the language/locale policy violation criteria.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Medium
Category
Not specified by scanner
Confidence
91% confidence
Finding

The workflow requires output as 剧本.md with Chinese-labeled fields such as 对白, 心理活动, and 旁白, and later sections continue to prescribe Chinese text handling rules. Because the file does not present this as an optional locale mode or ask the user to choose language, it imposes a specific language convention by default.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
93% confidence
Finding

The trigger phrases are broad consumer-style requests such as '把我的故事做成漫画' and '故事转漫画', which are likely to match ordinary user intents outside a narrowly scoped invocation. This can cause the skill to activate unexpectedly and gain access to powerful tools like ImageGen and Bash in contexts where the user did not clearly intend to invoke this workflow, increasing the risk of overreach or unintended tool use.

Content

No source excerpt is available for this finding.

Natural-Language Policy Violations

Low
Category
Not specified by scanner
Confidence
94% confidence
Finding

The HTML root element hard-codes lang="zh-CN", which enforces a specific language/locale in the template. There is no accompanying note that this is optional, user-selected, or justified as a region-specific template, so it appears to violate the locale-choice policy.

Content

No source excerpt is available for this finding.