T09 · Insecure Skill Coding Practices
- Location
SKILL.md:42- Finding
Shell Command Injection Through Unquoted User-Controlled Shopping Intent
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This shopping skill needs Review because it combines payment/scheduled-purchase authority with broad activation, weak credential handling, unsafe command/file patterns, no clear cancellation path, and a mock purchase path that reports success.
Only install after review and remediation. Require narrow explicit purchase intent, a final confirmation showing item, price, address, time, and total charge, a cancellation path for scheduled jobs, secure secret storage, fixed safe state paths, and a real provider-confirmed transaction flow or clear simulation labeling.
SKILL.md:42Shell Command Injection Through Unquoted User-Controlled Shopping Intent
scripts/seap-cli.js:124Arbitrary File Write Through Unvalidated Session Identifier
scripts/seap-cli.js:57Fabricated Purchase Success Misrepresents Financial Transactions
seap.config.json:4Plaintext Personal Delivery Address Committed in Configuration
The trigger condition activates on any message containing the single character “买”, which is overly broad for a skill that can search for products and ultimately place purchases. In this skill’s context, accidental activation is especially risky because it can begin a commerce flow and, combined with scheduled purchasing, could lead to unintended orders or user confusion around financial actions.
The documentation describes scheduled purchases and automatic execution but does not prominently warn that real orders will be placed later using stored payment credentials and delivery data. For a skill that can spend funds without the user being present at execution time, this omission increases the chance of uninformed consent and unsafe use.
The skill auto-triggers whenever the message contains the single character "买", which is far too broad for a capability that can search products and initiate real purchases. This creates a high risk of accidental activation from casual conversation, quoted text, or ambiguous requests, especially because the skill supports unattended scheduled purchases.
The skill documents storage of sensitive data including a payment token and delivery address, but does not present explicit warnings, handling constraints, or protections for those secrets. Because the token enables later unattended payment, insecure storage or casual handling could expose financial credentials and personal address information.
Referenced artifact was not completely inspected
依赖 `scripts/seap-cli.js` 执行相关命令。
The skill can execute actual purchases, including scheduled unattended purchases, yet the description does not clearly warn operators or users about this high-risk capability. In context, this omission is especially dangerous because the workflow combines broad triggering, persistent payment tokens, and deferred execution, which can enable unintended or unauthorized transactions.
The README is written entirely in Chinese and all trigger and usage examples assume Chinese input, such as matching the character “买”. There is no statement that the skill is intentionally China/Chinese-specific or that users may choose another language, which can violate language/locale policy if the skill is expected to support broader audiences.
The README instructs users to place authCode and secretToken directly into a config file but does not warn that these are sensitive secrets that must be protected from disclosure, logging, version control, or insecure file permissions. Because the token is used for payment-related automation, compromise could expose account access or enable unauthorized purchases.
The manifest trigger phrase is ambiguous and insufficiently constrained, making it easier for the skill to activate in contexts that do not reflect a clear purchase authorization. In a shopping skill tied to payment operations, ambiguous activation materially increases the chance of unintended workflow entry and downstream unsafe actions.
This code hardcodes Chinese-language output labels such as the heading, price, description, rating, store, and image fields. The file does not offer any language selection or explain that the skill is intentionally region-specific, which creates a locale-policy issue under the natural-language policy rules.
The CLI performs an unexpected side effect by writing search and purchase results to local disk, even though its stated purpose is shopping. In an agent/skill context, undocumented filesystem writes expand the capability surface and can leak data, overwrite files, or create persistence artifacts that downstream components did not expect.
The sessionId is user-controlled and is directly interpolated into a filesystem path for writeFileSync without validation. An attacker can supply path traversal or absolute path values to write JSON files outside the intended directory, potentially overwriting application files or planting data in sensitive locations accessible to the process.