T09 · Insecure Skill Coding Practices
- Location
SKILL.md:91- Finding
Shell Command Injection Through Unescaped Order Data
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill is a coherent flower-ordering assistant, but it collects delivery personal data and tells the agent to submit it with an unsafe raw shell curl command.
Review before installing. Use this only if you trust the flower-shop operator and are comfortable sending recipient delivery details to piaoleaf.tiaowulan.com. The order-submission step should be changed to a scoped HTTP integration with explicit user confirmation, validation, and JSON/form serialization instead of executing a generated curl command containing user input.
SKILL.md:91Shell Command Injection Through Unescaped Order Data
Hidden instructions were detected in comments or invisible text. These could contain malicious directives. Manual review is recommended.
---
name: tiaowulan-flower-shop
description: 跳舞兰订花技能。用户说"订花"、"买花"、"送花"、"浏览花束"、"花束推荐"、"花店"、"选一束花"等意图时触发。支持:商品浏览(关键词/分类/价格筛选)、商品详情查看(图片+价格)、智能推荐(按场合/收花人/预算)、下单、订单确认
---
The skill instructs collection of sensitive personal data including recipient name, phone number, full delivery address, card message, and delivery time, then submits it to an external service without any privacy notice, consent language, retention limits, or validation guidance. This creates meaningful privacy and compliance risk, and increases the chance of users disclosing personal data without understanding where it will be sent or how it will be handled.
The description says the skill triggers on broad phrases such as “订花”, “买花”, “送花”, “花店”, and “选一束花等意图”, which are common everyday shopping expressions rather than narrowly scoped invocation terms. It also does not provide exclusion conditions or negative examples, increasing the chance of unintended activation in general conversations about flowers or gifts.
The skill explicitly directs transmission of user-supplied PII to an external domain via a POST request. Even if this is part of legitimate order fulfillment, it is security-relevant because the skill provides no trust boundary explanation, no verification of endpoint legitimacy, no consent checkpoint, and no safeguards around handling or logging of the transmitted data.
必须全部收集完毕后再提交订单,不得遗漏任何必填字段。
使用 curl 提交订单:
curl -X POST "https://piaoleaf.tiaowulan.com/api/trade/CreateOrder" ^