T09 · Insecure Skill Coding Practices
- Location
scripts/monitor.py:17- Finding
Server-Side Request Forgery Through an Unrestricted Target URL
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill has a legitimate website-monitoring purpose, but its implementation gives broad network and file-write authority that users should review before installing.
Install only if you are comfortable with this skill making HTTP requests from your machine and writing a local state file. Run it in a restricted environment, avoid checking internal or metadata-service URLs, and do not pass sensitive paths to --state-file; a safer version would restrict URL targets and store state only in a dedicated private directory.
scripts/monitor.py:17Server-Side Request Forgery Through an Unrestricted Target URL
scripts/monitor.py:24Arbitrary File Overwrite and Predictable Temporary-State Symlink Attack
SKILL.md:29Unpinned and Unverified Runtime Dependency Installation
The skill advertises executable behavior that can read/write files and perform network access, but it does not declare any explicit tool scope or permissions. That omission weakens review and containment, because operators and automated systems cannot clearly enforce least privilege for a user-invocable skill that monitors arbitrary URLs and stores results.
The natural-language description and usage guidance are presented in Chinese, which effectively forces a specific language for users reading the skill documentation. The file does not offer an opt-in language choice or explain that the skill is intended only for a Chinese-speaking audience, which conflicts with the language/locale policy criteria.
The docstring and user-visible status messages are written in Chinese, including success and error outputs, without offering a language option or documenting a locale-specific requirement. This can violate language or locale policy when users are not given a choice or informed that the tool is region-specific.
Dynamic import() can load arbitrary modules at runtime, bypassing static analysis and potentially importing malicious code.
json.dump({
'hash': content_hash,
'status': status_code,
'last_check': str(__import__('datetime').datetime.now())
}, f)
return {
This code writes monitoring state to the path provided by --state-file, overwriting any existing file contents. Although the skill prints the monitoring result, it does not disclose that it will modify a local file, and the code lacks a comment or prompt warning users about this side effect.