T09 · Insecure Skill Coding Practices
- Location
src/event-bus.js:116- Finding
Object-Style Middleware Invocation Failure Causes Rate-Limit Bypass
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This is a coherent in-process event orchestration library with no hidden OS, network, credential, or persistence behavior, but it has dependency hygiene issues and a real rate-limit implementation bug.
Install only if you are comfortable with a Chinese-language Node.js library for in-process orchestration. Update the dev dependency lockfile before using it in CI, avoid feeding untrusted config or source files into its tooling until patched, and fix the middleware dispatch bug before relying on the built-in rate limiter as a security control.
src/event-bus.js:116Object-Style Middleware Invocation Failure Causes Rate-Limit Bypass
js-yaml 3.14.2 is flagged with multiple CPU consumption/DoS advisories involving crafted YAML merge structures and omap resolution. Although this instance is nested under a dev dependency path, parsing attacker-controlled YAML in tooling, CI, or local developer workflows could still cause excessive resource consumption or hangs.
brace-expansion 1.1.13 is associated with multiple denial-of-service issues due to pathological expansion behavior and memory growth. Even though it is transitive and dev-only here, many file-matching and CLI workflows consume attacker-influenced patterns, so malformed input could degrade developer tools or CI jobs.
browserslist 4.28.2 is flagged for crash/prototype-write and unbounded memory growth issues when given untrusted stats or distinct query inputs. In this project it is part of the development toolchain, so it is less severe than a production runtime dependency, but still a real risk for build systems or automation that ingest external configuration or stats data.
js-yaml 4.1.1 carries the same family of YAML parser CPU exhaustion issues as the 3.x finding, so this is not a false positive merely because another version is also present. In this lockfile it is used by developer tooling, which reduces blast radius but still leaves CI or local automation vulnerable to denial of service when handling attacker-controlled YAML.
This markdown file documents getEventHistory, clear(), and exportState() but provides no warning that these operations may expose historical event data or remove all stored orchestrator state. For markdown files, missing warnings about behaviors affecting user data or system integrity should be flagged.
The manifest mixes English naming with Chinese display text, description, tags, and category, but provides no indication that the skill is region-specific or that users can opt into this locale. That creates a natural-language policy concern because the skill presentation appears to enforce a specific language by default.
This markdown file contains user-facing natural language throughout, and it consistently forces a single language/locale experience. Under the policy, language constraints should either provide user opt-in/choice or be clearly justified as region-specific, which is not present here.
The file presents all user-facing instructions in a single language and does not offer an opt-in language choice or explain that the skill is intentionally region/language-specific. This can violate the language/locale policy when no justification or alternative is provided.
This markdown file presents the skill name, description, commands, and usage guidance entirely in Chinese. Under the language/locale policy, forcing a specific language without offering the user a choice or documenting the locale constraint can be a natural-language policy violation.
The document sets lang="en" at L003, which is a natural-language locale choice applied globally to the page. In this file there is no accompanying user opt-in or justification for enforcing English, while the embedded content itself includes Chinese text, making the fixed locale inconsistent and potentially contrary to a language-choice policy.
The natural-language comments and descriptive text for the main entry file are written in Chinese, including the file purpose and architectural description. This imposes a specific language context with no indication of user opt-in, alternative locale support, or documented justification for a region-specific skill.
The comments and descriptive text in this file are written in Chinese, such as the title and middleware descriptions, with no indication that the skill is region-specific or that users can opt into this language. Under the stated policy, forcing a specific language without user choice is a natural-language locale policy issue.
The HTML document declares lang="en" on L003, but the embedded visible text and code comments for the covered file are largely in Chinese later in the page. This creates a locale/language policy concern because the file forces an English language setting without offering user choice or reflecting the actual content language.
The lockfile pins @babel/core 7.29.0, which the supplied finding states is affected by an arbitrary file read issue via sourceMappingURL comment handling. In this skill context it is a development/test dependency rather than runtime application code, so exploitability is narrower, but it is still a real supply-chain risk if untrusted source files are processed during builds or tests.
baseline-browser-mapping 2.10.17 is reported vulnerable to invalid-input-triggered process termination. This appears to be a legitimate dependency issue, but in this lockfile it is a dev-only package used indirectly by browserslist-related tooling, making the practical risk mostly limited to denial of service in build or analysis workflows.
The package description is written only in Chinese, which imposes a specific language choice in user-facing metadata. Under the stated policy, a forced language or locale without offering user choice or documenting a justified regional scope is a natural-language policy concern.
Dependencies lack version pinning, allowing potential malicious package updates. Consider pinning versions.
"author": "王的奴隶 · 严谨专业版",
"license": "MIT",
"devDependencies": {
"jest": "^29.0.0",
"eslint": "^8.0.0"
},
"jest": {
Dependencies lack version pinning, allowing potential malicious package updates. Consider pinning versions.
"license": "MIT",
"devDependencies": {
"jest": "^29.0.0",
"eslint": "^8.0.0"
},
"jest": {
"testEnvironment": "node",
The file header and descriptive comments use Chinese exclusively, which is a natural-language locale choice embedded in the skill artifact. Under the policy, forcing a specific language without user opt-in or a documented regional justification is a policy concern.
This code file contains user-facing natural-language comments in Chinese, such as the module description and class documentation, but provides no indication that the language is configurable or intentionally region-specific. Under the stated policy, forcing a specific language without user opt-in can be a natural-language policy violation.
This JavaScript test file uses Chinese-only natural-language comments and test descriptions, such as the header comment and subsequent describe/test labels. Under the stated policy, forcing a specific language without user opt-in or documented regional justification is a natural-language policy issue.
This JavaScript test file contains natural-language comments and test descriptions in Chinese throughout, which effectively forces a specific language for maintainers and users interacting with the skill artifacts. The stated policy flags locale or language constraints when no opt-in or justification is provided.
This JavaScript test file uses Chinese natural-language strings throughout comments and test descriptions, which imposes a specific language on users and maintainers. Under the policy, language-specific behavior is only acceptable when the skill offers opt-in or clearly documents a justified locale constraint, neither of which is present in this file.