T09 · Insecure Skill Coding Practices
- Location
scripts/cache-manager.js:8- Finding
Sensitive Agent State Persisted in a Predictable Plaintext Cache
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill is a response-speed optimizer, but it also persists sensitive agent memory files and exposes an unsafe shell-command helper without enough scoping or controls.
Review before installing. This skill may improve speed, but it can copy sensitive agent and user memory files into a predictable plaintext cache and includes an exported arbitrary command executor. Install only in a trusted, sandboxed workspace after accepting that data persistence, or after removing the shell executor and narrowing/protecting the cache.
scripts/cache-manager.js:8Sensitive Agent State Persisted in a Predictable Plaintext Cache
scripts/parallel-executor.js:95Shell Command Injection Through Exported Parallel Command Executor
The skill description does not clearly disclose all operational behavior, including startup/bootstrap execution via the documented bootstrap command. Description-behavior mismatches are dangerous because operators may trust the declared purpose while overlooking automatic initialization or side effects that run outside expected user-triggered actions.
The skill description does not clearly disclose all operational behavior, including startup/bootstrap execution via the documented bootstrap command. Description-behavior mismatches are dangerous because operators may trust the declared purpose while overlooking automatic initialization or side effects that run outside expected user-triggered actions.
The skill description does not clearly disclose all operational behavior, including startup/bootstrap execution via the documented bootstrap command. Description-behavior mismatches are dangerous because operators may trust the declared purpose while overlooking automatic initialization or side effects that run outside expected user-triggered actions.
The module exposes parallelExecCommands(commands), which executes arbitrary shell commands via child_process.exec and runs them in parallel. In a skill whose stated purpose is response-speed optimization, this materially expands capability into arbitrary subprocess execution, creating command-injection and remote code execution risk if any caller passes user-influenced input.
The skill declares no explicit tool scope or permissions, yet its content describes code execution and cache-management behavior that implies environment and filesystem access. Missing scope declarations make it harder to review, constrain, and safely sandbox the skill, increasing the risk of unintended capability use.
The skill proposes persistent caching of user profile and memory summary data without notice, retention limits, or privacy controls. Persisting conversational state in files can expose sensitive personal or behavioral information if accessed by other skills, users, or processes, especially when refreshed automatically.
An auto-trigger that runs on every message without scope constraints can cause pervasive, hard-to-audit behavior and may process sensitive conversations unnecessarily. In this skill, that risk is amplified by background execution and cache refresh logic, which could repeatedly touch files or state without clear user intent.
This JavaScript file contains user-facing natural-language strings and comments entirely in Chinese, including startup and error messages. The file does not offer any language choice or explain a justified region-specific requirement, which creates a locale policy concern under the rule for natural-language policy violations.
The documentation describes periodic refresh and persistent storage of user_profile, memory_summary, and related state files, but does not clearly disclose this persistence to the user or define retention and protection controls. This is risky because user-related data and conversation-derived summaries may be stored automatically, expanding privacy exposure if accessed, retained too long, or used without informed consent.
The skill declares an automatic trigger on every message, which can cause it to run across nearly all conversations without clear scoping or user opt-in. In a skill that performs caching and background processing, this broad trigger increases the chance of unnecessary data handling, unintended persistence, and surprise execution outside the user’s expectations.
This code includes natural-language descriptions and console output in Chinese, indicating the skill effectively forces a specific language for users and operators. The file does not provide any opt-in, fallback language, or justification that it is intentionally limited to a Chinese-speaking context.
The code performs parallel subprocess execution without any guardrails or warning to callers about the risks of running shell commands. Because exec invokes a shell, metacharacters and concatenated input can trigger unintended commands, and parallelism can amplify damage by executing multiple harmful operations at once.
SQP-3 适用于所有文件类型。该技能说明整体强制以中文描述使用方式和规则,未见提供多语言选项、用户选择机制或明确说明这是仅面向中文区域的版本,存在语言/locale 策略上的潜在问题。
The file’s human-facing comments and runtime log/error strings are consistently in Chinese, including status and timeout messages. This imposes a specific language/locale without any indication of user opt-in or documented justification, which matches the language-policy concern for natural-language behavior.