Back to skill

Security audit

Dnd Character Generator

Security checks for vulnerabilities and agentic risk

Overview

The skill does what it claims, but a command-line parsing bug can accidentally send the user's API token as image prompt text.

Review before installing. Use only a token you are comfortable sending to the Neta/Tales of AI service, avoid the documented token-only command until the parser is fixed, and prefer a pinned or ClawHub-managed install path instead of the unpinned npx command.

Vulnerability Patterns
  • Insecure DependenciesIntroduces malicious components through unsafe dependency sources
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
Findings (2)

T09 · Insecure Skill Coding Practices

Warning
Location
dndcharactergenerator.js:4
Finding

API Token Can Be Misclassified and Transmitted as Image Prompt Data

Content
View full analysis
!a.startsWith('--')) || 'DnD fantasy character portrait, detailed armor and weapons, dramatic lighting, epic fantasy art style, highly detailed character design, tabletop RPG hero'; const tokenIndex = args.indexOf('--token'); const tokenFlag = tokenIndex !== -1 ? args[tokenIndex + 1] : null; ``` The resulting value is subsequently inserted into the API request body: ```js const body = { storyId: 'DO_NOT_USE', jobType: 'universal', rawPrompt: [{ type: 'freetext', value: PROMPT, weight: 1 }], width, height, meta: { entrance: 'PICTURE,VERSE' }, context_model_series: '8_image_edit', }; ``` The README explicitly documents a prompt-free invocation at `README.md:29`: ```bash node dndcharactergenerator.js --token YOUR_TOKEN ``` ### Technical Analysis The program identifies the prompt by selecting the first command-line argument that does not begin with `--`. This logic does not distinguish positional arguments from values belonging to named options. For the documented command `node dndcharactergenerator.js --token YOUR_TOKEN`, the argument array contains `--token` followed by `YOUR_TOKEN`. Because the token value does not begin with `--`, it is selected as `PROMPT`. The same value is also correctly selected as `TOKEN`. As a result, the credential is transmitted both as the authentication header and as the image-generation prompt: ```js const HEADERS = { 'x-token': TOKEN, 'x-platform': 'nieta-app/web', 'content-type': 'application/json', }; ``` Prompt data may be handled by additional backend components such as moderation, generation, telemetry, debugging, or prompt-retention systems. This unnecessarily e ...[truncated 1148 chars]
Remediation
View remediation

T08 · Insecure Dependencies

Note
Location
README.md:7
Finding

Documented Installation Command Executes an Unpinned Third-Party Package

Content
View full analysis
Remediation
View remediation
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
  • Prompt InjectionInstruction Override, Hidden Instructions, Exfiltration Commands
  • Privilege EscalationExcessive Permissions, Sudo/Root Execution, Credential Access
  • Supply ChainUnpinned Dependencies, External Script Fetching, Obfuscated Code
Findings (5)

Rp1

Medium
Category
MCP Rug Pull
Confidence
87% confidence
Finding

The README instructs users to install the skill via npx skills add omactiengartelle/dnd-character-generator without pinning a specific package or skill version. This creates a supply-chain risk because future changes to the remotely fetched installer or referenced package could cause users to execute unexpected code at install time, and README copy-paste commands are commonly trusted and run verbatim.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
89% confidence
Finding

The phrase "Use when someone asks to generate or create dnd character art generator images" is awkward and underspecified, and it does not clearly define what user requests should or should not invoke this skill. It lacks concrete trigger examples or exclusion conditions, which can lead to unintended activation from loosely related requests about character art or image generation.

Content

No source excerpt is available for this finding.

Rp1

Medium
Category
MCP Rug Pull
Confidence
70% confidence
Finding

npx commands without a version suffix (e.g. @1.0.0) create a rug-pull risk if the upstream server is compromised and publishes a malicious update.

Content

No source excerpt is available for this finding.

External Transmission

Medium
Category
Data Exfiltration
Confidence
60% confidence
Finding

Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.

Content

Scanner excerpt · dndcharactergenerator.js (reported line 97)May include surrounding context.

js
}

  let taskUuid;
  const makeRes = await request('POST', 'https://api.talesofai.com/v3/make_image', body);

  if (typeof makeRes === 'string') {
    taskUuid = makeRes.trim();

External Transmission

Medium
Category
Data Exfiltration
Confidence
60% confidence
Finding

Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.

Content

Scanner excerpt · dndcharactergenerator.js (reported line 112)May include surrounding context.

js
}

  let taskUuid;
  const makeRes = await request('POST', 'https://api.talesofai.com/v3/make_image', body);

  if (typeof makeRes === 'string') {
    taskUuid = makeRes.trim();