T09 · Insecure Skill Coding Practices
- Location
scripts/lock.js:33- Finding
Non-atomic process lock permits concurrent workflow execution
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill is coherent and not malicious, but its bundled workflow scripts include real file-locking and temporary-file weaknesses that users should review before adopting.
Review the bundled scripts before using them for business-critical or non-idempotent workflows. Store state and lock files in a private directory, harden temporary-file and lock creation, and avoid sending raw exception messages to Telegram or any external alert channel.
scripts/lock.js:33Non-atomic process lock permits concurrent workflow execution
scripts/workflow-template.js:42Predictable temporary paths allow symlink-based file overwrite
SKILL.md:190Unredacted exception messages may disclose sensitive data to Telegram
The skill references environment variables (ALERT_TELEGRAM_TOKEN, ALERT_CHAT_ID, WORKFLOW_STATE_PATH) and includes executable code patterns, but it does not declare any explicit tool scope or permissions boundary. In an agent ecosystem, this can cause the skill to be invoked with broader runtime capabilities than intended, increasing the chance of unauthorized access to secrets or environment-dependent behavior without clear operator awareness.
The trigger phrases are very broad (automate, workflow, multi-step, retry, error handling, resilient) and could cause this skill to activate for many generic user requests outside its narrow intended scope. Over-broad matching can steer an agent into applying file, state, locking, and alerting patterns in contexts where they are unnecessary or risky, increasing the attack surface and the chance of unintended tool use.
No suspicious patterns detected.