T09 · Insecure Skill Coding Practices
- Location
references/olares-files-share.md:63- Finding
Weak Public-Share Password Exposed Through Command-Line Arguments
- Content
View full analysis
Vulnerability Details
File Location:
references/olares-files-share.md, lines 63–65
Vulnerability Type: Public-share credential exposure and weak example password
Risk Level: Mediumbash # Public upload-only inbox with explicit password + size cap. olares-cli files share public drive/Home/Inbox/ --upload-only \ --password drop --expire-days 30 --upload-size-limit 100MTechnical Analysis
The example supplies the public-share password through the
--passwordcommand-line argument. Command-line secrets can be retained in shell history and may be visible to local process-monitoring tools while the command executes.The literal password
dropis also short and predictable. Because the share is publicly reachable to anyone possessing its URL and password, documentation that encourages a weak credential increases the risk of unauthorized access. Although this is an example rather than a hardcoded production credential, users may copy it directly.Attack Path
- A user copies the documented command and creates a public upload-only share using
dropas its password. - The command, including the password, is retained in shell history or observed through local process inspection.
- An attacker obtains or discovers the corresponding public-share URL.
- The attacker uses the exposed or predictable password before the 30-day expiration.
- The attacker gains the upload capability granted by the public share and may place unauthorized content into the shared directory.
Impact Assessment
Exploitation does not grant general Olares account access or expose authentication tokens. It grants the permissions configured for the affected public share. In this example, the attacker could upload files into the selected inbox until the link expires or its password is changed. This may enable unauthorized storage consumption, malicious file placement, or abuse of workflows that process uploaded conte ...[truncated 3 chars]
- A user copies the documented command and creates a public upload-only share using
- Remediation
View remediation
Remediation Suggestions
- Add public-share support for
--password-stdinor secure file-descriptor input. - Replace the literal password with an auto-generated password or a clearly marked secure-input placeholder.
- Warn users that
--passwordcan expose credentials through process arguments and shell history. - Prefer the CLI's documented random-password generation behavior when an explicit password is unnecessary.
- Require sufficiently long, randomly generated passwords when users provide credentials explicitly.
- Advise users to transmit the share URL and password through separate secure channels.
- Add public-share support for
