T08 · Insecure Dependencies
Warning
- Location
- SKILL.md:1058
- Finding
- Unpinned External Dependency Installation## Vulnerability Details **File Location**: `SKILL.md`, lines 1058–1064 **Vulnerability Type**: Supply-chain exposure through an unpinned external dependency **Risk Level**: Medium ### Vulnerable Code ```text This means `ofox-video-core` isn't installed alongside this skill — not that anything is broken. This skill delegates all execution to it and reaches it by relative path. Fix: `npx skills add ofoxai/skills` (the whole repo). Say that plainly rather than relaying the raw path error, which names neither the missing skill nor the fix. Expect the shared reference files to be missing for the same reason: ``` ### Technical Analysis The audited artifact does not include the `ofox-video-core` component to which it delegates API-key handling, request submission, polling, and output download. If that component is absent, the Skill instructs the agent to run an unversioned `npx` command that installs the entire mutable `ofoxai/skills` repository. The command does not pin the `skills` installer package, an upstream release, or an immutable commit. It also does not specify or verify a checksum or cryptographic signature. Therefore, code retrieved and executed during installation may differ from the code that existed when this Skill was reviewed. Installing the whole repository expands the dependency and executable surface beyond the single core component required by the declared video-generation functionality. Because the installed core script receives access to `OFOX_API_KEY` and user-selected product images, compromise of either the package-resolution path or upstream repository would cross a sensitive trust boundary. The documented remote transmission of prompts and selected product images is otherwise consistent with the Skill's declared cloud video-generation purpose. The Skill also requires a dry-run estimate and explicit approval before paid submission. However, the absent delegated implementation prevents this audit from verifying its network destinatio ...[truncated 1622 chars]
- Remediation
- ## Remediation Suggestions 1. Pin the `skills` installer to a reviewed package version rather than invoking an unversioned package through `npx`. 2. Pin `ofoxai/skills` to an immutable commit hash or signed release tag. 3. Install only `ofox-video-core` instead of the entire repository to minimize dependency and executable scope. 4. Verify downloaded content using a published cryptographic checksum or signature before installation or execution. 5. Prefer packaging the reviewed `ofox-video-core` implementation with the Skill so its effective behavior is included in the audit boundary. 6. Declare the exact compatible dependency version in machine-readable metadata and fail closed if another version is present. 7. Before invoking the dependency, verify its path, ownership, permissions, version, and integrity to reduce local replacement risk. 8. Ensure the delegated script receives only the required environment variables and selected input files. Avoid exposing unrelated credentials or directories. 9. Document the external processing destination, retention policy, and types of data uploaded so users can provide informed consent before transmitting product assets. 10. Preserve the existing dry-run and explicit approval gate, and separately request confirmation before uploading assets that may contain confidential product information.