T09 · Insecure Skill Coding Practices
- Location
lib/storage.py:76- Finding
Sensitive customer and financial data is stored without encryption
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This invoice skill runs locally, but it overstates security and compliance protections for sensitive billing data, so it should be reviewed before installation.
Review this skill carefully before installing. Treat created invoices, contacts, seller details, and IBAN/BIC settings as persistent plaintext local files, not encrypted records. Do not rely on the advertised VIES checks, credit-note workflow, overdue/reminder handling, or deletion/reset commands unless you verify the implementation yourself. Avoid running setup in a sensitive environment unless the unpinned pip upgrade is acceptable.
lib/storage.py:76Sensitive customer and financial data is stored without encryption
setup.sh:78Installer downloads and installs an unpinned pip release
Claiming encrypted storage, overdue/reminder handling, credit-note support, and VIES-backed validation without clear evidence can lead to confidentiality, integrity, and compliance failures. In the context of an invoicing skill, such claims can cause users to store customer VAT, address, and banking data believing it is protected or externally verified when it may not be.
Claiming encrypted storage, overdue/reminder handling, credit-note support, and VIES-backed validation without clear evidence can lead to confidentiality, integrity, and compliance failures. In the context of an invoicing skill, such claims can cause users to store customer VAT, address, and banking data believing it is protected or externally verified when it may not be.
Claiming encrypted storage, overdue/reminder handling, credit-note support, and VIES-backed validation without clear evidence can lead to confidentiality, integrity, and compliance failures. In the context of an invoicing skill, such claims can cause users to store customer VAT, address, and banking data believing it is protected or externally verified when it may not be.
Claiming encrypted storage, overdue/reminder handling, credit-note support, and VIES-backed validation without clear evidence can lead to confidentiality, integrity, and compliance failures. In the context of an invoicing skill, such claims can cause users to store customer VAT, address, and banking data believing it is protected or externally verified when it may not be.
The skill claims that all invoice data is encrypted and stored locally, but seller/payment configuration is written as plaintext JSON files with no encryption or access-control handling shown. Because these files contain sensitive financial and identifying data such as VAT, IBAN, BIC, and contact details, local compromise, backups, or accidental file exposure can leak confidential business information.
Skill establishes unauthorized persistence across sessions via cron jobs, startup scripts, or state files. Session persistence allows an attacker to maintain access beyond the current interaction.
## What It Does
- Create professional invoices from natural language input in Dutch or English
- Automatically calculate VAT/BTW using correct Belgian rates (0%, 6%, 12%, 21%)
- Generate Peppol BIS 3.0 compliant UBL XML invoices (mandatory for B2B from January 2026)
- Manage customer contacts with automatic VAT-ID validation
The README makes inconsistent privacy/network claims: it says there are no external API calls and VAT-ID validation is cached locally, while the skill metadata and feature description reference validation against EU VIES. If users rely on the stronger privacy claim, they may expose customer VAT identifiers and business data to external services without informed consent. In a billing tool handling regulated business records, misleading statements about network behavior and data flows are security-relevant.
The skill advertises and instructs use of shell execution, local file reads/writes, and environment-dependent setup, but it does not declare an explicit tool scope such as permissions or allowed-tools. That creates an authorization ambiguity where an agent may invoke powerful capabilities without clear least-privilege boundaries, increasing the chance of unintended command execution or filesystem modification.
Broad trigger phrases like generic terms for invoices or VAT increase the chance of unintended activation in unrelated conversations. Because this skill can run shell-backed commands, create records, and modify local data, accidental invocation could lead to unwanted invoice operations or data exposure from benign user queries.
The documented commands include destructive operations such as contact deletion and configuration reset, but the skill description does not warn about the consequences or indicate any confirmation requirement. In a business invoicing context, accidental deletion or reset could remove customer records, seller settings, or payment details and disrupt accounting workflows.
The skill states that VAT-ID validation uses the EU VIES service but does not warn users that submitted VAT identifiers and possibly related metadata are sent to an external service. This is a privacy and data-governance issue, particularly for business identifiers and customer records processed in a supposedly local-storage workflow.
The file uses Belgian-specific terminology and tax defaults such as "Belgian VAT Rates," Dutch VAT labels like "standaard," and later defaults the country to BE. This creates a natural-language locale policy constraint embedded in the skill without any visible user choice or explicit justification in this file.
The configuration commands persist sensitive seller and payment data to local files without warning users that financial identifiers will remain on disk. In this skill context, that includes IBAN/BIC and company identity data, so silent persistence can expose secrets through shared machines, backups, source-control mistakes, or weak filesystem permissions.
The manifest says the skill manages customer contacts with VAT-ID validation against EU VIES. In this code, buyer VAT numbers are auto-saved into contacts during invoice creation and also accepted in contact add/config flows without any validation call, while validation only exists as a separate manual command.
During invoice creation, buyer contact data is automatically persisted if a VAT number is present, without an explicit prompt or disclosure at the point of collection. In an invoicing skill that processes personal and company data, silent retention increases privacy risk, surprises users, and may create regulatory exposure if operators assume one-off processing rather than durable storage.
The manifest advertises 'credit note generation for returns or corrections,' but invoice creation and XML regeneration hardcode UBL type_code '380' for invoices and expose no command or branch for credit notes. This is a functional mismatch between the stated capability and actual code behavior.
The manifest says the skill tracks invoices through a complete lifecycle including 'overdue' status with automatic payment date logging and reminders. In code, the only allowed status transitions are draft, sent, paid, and cancelled, and there is no logic here for overdue handling, payment-date recording, or reminder generation.
Skill establishes unauthorized persistence across sessions via cron jobs, startup scripts, or state files. Session persistence allows an attacker to maintain access beyond the current interaction.
PY_VERSION="$($PYTHON --version 2>&1)"
echo " Found: $PY_VERSION"
# Step 2: Create data directory
echo "[2/6] Creating data directory..."
mkdir -p "$DATA_DIR"
if [ "$PLATFORM" != "windows" ]; then
Commands invoke sudo or root privileges. Verify this elevated access is necessary and justified.
echo "[2/6] Creating data directory..."
mkdir -p "$DATA_DIR"
if [ "$PLATFORM" != "windows" ]; then
chmod 700 "$DATA_DIR"
fi
echo " Data directory: $DATA_DIR"
Skill's behavior or capabilities extend beyond its stated purpose. Scope creep allows an agent to perform actions unrelated to its documented functionality, increasing the attack surface.
so.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
This markdown file describes that invoice data and customer information are stored locally in ~/.einvoice/ and in a local SQLite database, but it frames this only as a privacy feature rather than a user warning. Because the skill handles potentially sensitive financial and customer data, the description should more explicitly warn users that invoking the skill creates persistent local records and exported files on disk.
The module docstring states that it parses only Dutch and English invoice descriptions, which is a natural-language locale constraint. Under the policy rule, language limitations should be user-selectable or clearly justified; this file presents the restriction as a fixed behavior without opt-in or justification.
This code persists invoice and contact records into a local SQLite database, which is a user-data write operation covered by the missing-warning rule for code files. Although the functions have technical docstrings, there is no user-facing warning, confirmation, or visible disclosure here that business and contact data will be stored on disk.