T09 · Insecure Skill Coding Practices
- Location
identity.py:31- Finding
Private keys may be stored unencrypted with inherited filesystem permissions
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This identity skill does what it says, but it needs review because it can create long-lived private keys insecurely and can write key files outside the intended folder.
Review before installing in any environment where agent keys matter. Use only in an isolated, non-privileged environment, provide a password for generated keys, restrict key-directory permissions yourself, avoid command-line passwords for real secrets, and use simple safe agent names without slashes or parent-directory components.
identity.py:31Private keys may be stored unencrypted with inherited filesystem permissions
identity.py:47Unsanitized agent names permit writes outside the intended key directory
SKILL.md:5Cryptography dependency is installed without version or integrity pinning
The manifest description limits the skill's purpose to signing and verifying agent messages, but the code also creates new private/public key material on disk and constructs signed agent identity cards with metadata like capabilities and endpoints. Key management and agent-card issuance are broader identity-management functions than the narrower manifest description suggests.
The Ed25519 private key may be serialized with NoEncryption() when no password is supplied, causing sensitive signing material to be stored on disk in plaintext. In an agent environment, compromise of the host, workspace, backups, or logs exposing the file path can lead to key theft and full impersonation of the agent.
The RSA private key may likewise be written using NoEncryption() when no password is provided, leaving long-lived private key material exposed at rest. If an attacker obtains the file, they can forge signatures, impersonate the agent, and undermine any trust model built on this identity mechanism.
No suspicious patterns detected.