T09 · Insecure Skill Coding Practices
- Location
src/config.ts:71- Finding
Tool arguments are exported by default with incomplete secret redaction
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This is a real Logfire observability plugin, but it defaults to sending tool arguments and raw error details to Logfire with privacy controls that do not reliably cover common secret formats.
Review this before installing in a workspace that handles credentials, customer data, private files, or production operations. Set captureToolInput and captureStackTraces to false unless explicitly needed, keep captureToolOutput and captureMessageContent disabled, treat redaction as best-effort rather than guaranteed, restrict Logfire project access, and upgrade the flagged dependencies before broad deployment.
src/config.ts:71Tool arguments are exported by default with incomplete secret redaction
src/hooks/tool-result-persist.ts:60Error messages and native exception stacks bypass telemetry privacy controls
protobufjs 7.5.4 has multiple serious advisories including potential code generation abuse and denial-of-service conditions. Because this package is used transitively by gRPC/OTLP telemetry components and the skill is built around OpenTelemetry export/import paths, attacker-influenced protobuf payloads may be in scope depending on enabled exporters or parsers.
The declared description describes an observability/logging skill related to Pydantic Logfire and OpenTelemetry-style tracing. The supplied code does not implement any runtime observability, tracing, metrics, tool spans, or related integrations. Instead, it is an ESLint configuration file used for static analysis and code quality enforcement in a TypeScript project. This is a materially different primary purpose, so the description does not accurately represent the code.
The declared description suggests a full observability/tracing integration for Pydantic Logfire, including OTEL GenAI traces, tool spans, token metrics, and distributed tracing. The actual code chunk does not implement or exercise those capabilities; it only contains unit tests for building a Logfire trace URL. This is a materially different and much narrower purpose than the declared description, so it should be flagged as a mismatch.
There is a strong description-behavior mismatch. The declared purpose centers on observability and tracing features associated with Pydantic Logfire and OpenTelemetry. However, the provided code is only a test suite for generic utility functions. While secret redaction and capture preparation could be supporting pieces in a logging/observability system, the chunk’s primary behavior is unrelated utility testing rather than tracing, telemetry, or metrics. No resource access, triggers, or permissions are evident, but the main capability described is materially different from what this code actually covers.
The declared description is about observability and tracing functionality, but the supplied code only configures the Vitest test runner and coverage behavior. It does not implement or expose Logfire observability, OTEL tracing, token metrics, tool call spans, or distributed tracing. This is a materially different primary purpose, so it is a clear mismatch.
The document defines a business automation and multi-agent control plane that is materially broader than the declared observability-only skill purpose. Scope mismatch is dangerous because it can smuggle privileged capabilities, external integrations, and autonomous workflow behavior into an environment where operators expect tracing-only behavior and may grant trust or deployment approval on that basis.
This section adds webhook-triggered agent execution, REST control of workflows, and shared-memory APIs, which are active control and data-plane features rather than observability. That creates hidden authority to send messages, trigger backend actions, and move data across systems under the cover of a tracing-oriented skill description.
Spawning Claude Code subprocesses introduces code-execution and repository-modification capability that is unrelated to observability. In practice this can be leveraged to run shell commands, alter source, access credentials available to the subprocess, or perform high-impact actions through inherited developer tooling and auth context.
The skill expands into Gmail, Drive, Calendar, HubSpot, LinkedIn, and Apollo integrations far beyond observability needs. Such breadth increases blast radius by granting access to sensitive communications, documents, CRM data, and external business systems without users expecting that level of reach from the skill metadata.
@grpc/grpc-js 1.14.3 is flagged for malformed-request and malformed-compression denial-of-service issues. In this package context it is a transitive runtime dependency via OpenTelemetry exporters, so if the skill exposes gRPC telemetry endpoints or processes attacker-influenced telemetry traffic, crashes are plausible.
@opentelemetry/exporter-prometheus 0.57.2 is reported vulnerable to process crash via malformed HTTP request. In an observability skill, Prometheus export functionality is directly aligned with expected use, so a malformed scrape or probe could potentially trigger denial of service on exposed metrics endpoints.
@opentelemetry/propagator-jaeger 1.30.1 is flagged for denial of service via unhandled input. Since this package is used for trace-context propagation, untrusted inbound tracing headers could trigger failures in services using this propagator, especially in internet-facing environments.
@opentelemetry/sdk-node 0.57.2 inherits exposure from the vulnerable Prometheus exporter included in the SDK bundle. Because this skill centers on telemetry collection/export, the vulnerable feature is more likely to be enabled than in a generic package.
Dependency has known vulnerabilities (CVEs). Using packages with unpatched security flaws exposes the environment to known exploits.
Dependency has known vulnerabilities (CVEs). Using packages with unpatched security flaws exposes the environment to known exploits.
Dependency has known vulnerabilities (CVEs). Using packages with unpatched security flaws exposes the environment to known exploits.
Dependency has known vulnerabilities (CVEs). Using packages with unpatched security flaws exposes the environment to known exploits.
Dependency has known vulnerabilities (CVEs). Using packages with unpatched security flaws exposes the environment to known exploits.
Dependency has known vulnerabilities (CVEs). Using packages with unpatched security flaws exposes the environment to known exploits.
Dependency has known vulnerabilities (CVEs). Using packages with unpatched security flaws exposes the environment to known exploits.
picomatch 4.0.3 is a direct dependency of the package, not merely dev-only. The advisory covers method injection and ReDoS in glob parsing, so if the skill matches attacker-controlled patterns or path selectors, this could cause incorrect authorization/filtering or denial of service.
Dependency has known vulnerabilities (CVEs). Using packages with unpatched security flaws exposes the environment to known exploits.
Dependency has known vulnerabilities (CVEs). Using packages with unpatched security flaws exposes the environment to known exploits.
The README prominently advertises full lifecycle tracing, tool calls, token metrics, and stack traces, but does not provide a strong upfront warning that these telemetry features can capture and export sensitive operational data to a third-party observability backend. In an agent context, traces may include prompts, tool arguments, file paths, error details, and other sensitive metadata, so insufficient privacy guidance can lead to accidental data exposure through normal use.
The configuration example presents captureToolInput as a normal feature and even enables it in the sample, while only briefly noting that it records tool arguments. In this plugin's context, tool arguments can contain secrets, file contents, prompts, credentials, or personal data, so documenting it without a strong warning increases the risk of users enabling sensitive-data collection unintentionally.