T09 · Insecure Skill Coding Practices
- Location
SKILL.md:31- Finding
Hard-Coded Application Identifier in a State-Changing Workflow
- Content
View full analysis
Vulnerability Details
File Location:
SKILL.md:31-36andreferences/workflow.md:6-11,48-49,61-67
Vulnerability Type: Hard-coded resource identifier used for backend mutations
Risk Level: MediumVulnerable Code Snippets
From
SKILL.md:31-36:markdown - `donation_app_list?wapc_app_id=806` is the best source for row IDs and saved values. - `account/update_app_detail` saves a single text field for one row. - `account/upload_app_img?id=<row id>` uploads the evidence image for that row. - `account/check_detail` must return `{"state":"ok"}` before final submission. - `account/app_save` stores the applicant info modal fields.From
references/workflow.md:6-11:markdown 1. Open the WAPC page on `mulandxc.com`. 2. Inspect `account/donation_app_list?wapc_app_id=806`. 3. Save text fields with `account/update_app_detail`. 4. Upload the LoTW evidence image with `account/upload_app_img?id=<row id>`. 5. Recheck `account/check_detail`. 6. If the check passes, open the applicant-info modal and call `on_save()`.From
references/workflow.md:48-49:markdown - `POST /account/check_detail` with `wapc_app_id=806`From
references/workflow.md:61-67:markdown Payload fields: - `po.id=806` - `po.is_qrp` - `po.member_callsign` - `po.member_name` - `po.member_phone` - `po.address`Technical Analysis
The reusable skill embeds application ID
806in read, validation, and persistence operations. It does not instruct the agent to derive the active application identifier from the authenticated session or verify that the application belongs to the intended user before performing mutations.The workflow first obtains row identifiers from the fixed application and then uses those identifiers with text-update and image-upload endpoints. It subsequently validates the same fixed application and stores applicant information using
po.id=806. Because the documentation also identifies some artifacts as session-specific, carrying t ...[truncated 1856 chars]- Remediation
View remediation
Remediation Suggestions
- Remove application ID
806from reusable skill instructions and examples. - Discover the active application identifier from the current authenticated WAPC page or a trusted first-party session endpoint.
- Before any update or upload, verify that the application has the expected account identity, callsign, award type, and ownership context.
- Verify that every row ID returned by the list endpoint belongs to the freshly discovered application before using it in mutation requests.
- Reject stale identifiers retained from previous sessions and stop if the current application cannot be unambiguously identified.
- Display the resolved application ID and intended callsign to the user and require explicit confirmation immediately before final submission.
- Keep session-specific screenshots, row IDs, and application identifiers outside reusable reference documentation.
- On the server, enforce object-level authorization for listing, row updates, uploads, validation, and applicant-data persistence. Do not rely on identifiers supplied by the client as proof of ownership.
- Add concurrency or freshness protection, such as a server-issued nonce or version token, to prevent updates against stale application state.
- Minimize handling of applicant personal data and avoid logging names, telephone numbers, or addresses in skill output or persistent local files.
- Remove application ID
