T09 · Insecure Skill Coding Practices
- Location
scripts/config_manager.py:133- Finding
Plaintext Storage of Feishu Credentials and Private WhatsApp Messages
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill is Review-worthy because it monitors private WhatsApp chats and exports matches to Feishu while leaving privacy, credential, and network exposure safeguards under-scoped.
Install only if you are authorized to monitor the specific WhatsApp chats and export their contents to Feishu. Keep the OpenClaw gateway bound to localhost or protect it with authenticated TLS, avoid opening the port broadly, store Feishu secrets outside plaintext config where possible, do not use the config-printing command with real secrets, pin dependencies, and review setup/reset commands before running them on an existing deployment.
scripts/config_manager.py:133Plaintext Storage of Feishu Credentials and Private WhatsApp Messages
run_skill.sh:77Feishu Credentials Exposed Through the Configuration Command
scripts/whatsapp_client.py:19Unauthenticated Plaintext Access to the OpenClaw WhatsApp Gateway
scripts/message_processor.py:100Regular Expression Denial of Service in Message Filtering
requirements.txt:2Automatic Installation of Unpinned Third-Party Dependencies
scripts/setup.py:125Setup Script Overwrites Existing Configuration and Project Files Without Confirmation
The skill explicitly enables continuous monitoring of WhatsApp chats and export of matching message content, sender data, and timestamps to Feishu, but it does not prominently warn users about privacy, consent, cross-system data sharing, or legal/compliance implications. In this context, the absence of clear disclosure and guardrails materially increases the risk of unauthorized surveillance, collection of third-party communications, and improper exfiltration of sensitive data to another platform.
Referenced artifact was not completely inspected
python scripts/setup.py
Referenced artifact was not completely inspected
python scripts/setup.py
Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns).
# 删除所有数据和日志
rm -f data/matched_messages.json
rm -f logs/whatsapp-monitor.log
# 重置配置文件
Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns).
# 删除所有数据和日志
rm -f data/matched_messages.json
rm -f logs/whatsapp-monitor.log
# 重置配置文件
rm -f config/whatsapp-targets.json
Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns).
rm -f logs/whatsapp-monitor.log
rm -f config/whatsapp-targets.json rm -f config/feishu-settings.json python scripts/setup.py
Tool parameters are crafted to achieve unintended or unsafe behavior. Parameter abuse can bypass intended safety checks (e.g. shell=True, --force, dangerous glob patterns).
rm -f config/whatsapp-targets.json rm -f config/feishu-settings.json python scripts/setup.py
Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
env/
venv/
.venv/
.env
*.log
"""
with open(gitignore_path, 'w', encoding='utf-8') as f:
The skill description explains how to trigger WhatsApp monitoring and export behavior but does not clearly warn users that it processes potentially sensitive private communications. In a messaging-monitoring context, missing privacy and consent warnings can lead to deployment without informed consent, creating serious confidentiality, compliance, and insider-misuse risks.
Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
获取 API 凭证
配置 OpenClaw
The generated README instructs users to monitor WhatsApp messages and export their contents, senders, attachments, and chat links to Feishu, but it does not warn about consent, privacy, retention, or legal/compliance implications. In this skill context, that omission is materially risky because the tool is explicitly designed for surveillance-like collection and third-party transfer of potentially sensitive communications.
The file begins in English but switches into Chinese for key setup and workflow instructions, which can impose a specific language on users without opt-in. There is no statement that the skill is intended only for Chinese-speaking users or that alternative language documentation is available.
The guide describes continuous monitoring of WhatsApp messages, keyword filtering, storage, and export to Feishu, but it does not warn users about privacy, consent, data retention, or cross-system sharing of message content. This omission can lead to unauthorized surveillance or mishandling of personal/business communications, especially because the skill processes sensitive chat data by design.
The reset section instructs users to delete message data, logs, and configuration files without clearly warning that the action is irreversible and may erase audit trails and credentials/configuration state. In operational environments, this can cause accidental data loss and hinder forensic review or recovery after incidents.
The natural-language content in target names, identifiers, and keyword lists is entirely Chinese, which suggests the skill is configured for a specific language/locale by default. There is no indication in this file that users can choose another language or that the locale restriction is explicitly documented as intentional and justified.
The keyword list contains broad, common terms such as '问题', '帮忙', and '会议' that are likely to appear in many normal conversations. In a monitoring configuration, this can cause over-collection, false alerts, or unintended actions against chats or contacts that were not meant to be monitored, increasing privacy and operational risk.
This Python file contains user-facing natural-language strings and documentation entirely in Chinese, including the module description and later console output, with no indication that language selection is optional. Under the policy, forcing a specific language without user opt-in is a natural-language policy violation unless the locale restriction is clearly justified.
Dynamic import() can load arbitrary modules at runtime, bypassing static analysis and potentially importing malicious code.
missing_packages = []
for package in required_packages:
try:
__import__(package)
except ImportError:
missing_packages.append(package)
The documented trigger conditions are broad enough that a general conversation mentioning WhatsApp monitoring concepts could activate the skill unintentionally. Because this skill monitors and exports private messages, accidental activation increases the risk of unauthorized surveillance, collection, or forwarding of sensitive communications.
The document states that the skill monitors WhatsApp messages and later documents endpoints for reading chats/messages and sending messages, which can affect user privacy and communications. Although there is a later generic security section, it does not clearly warn users up front that the integration can access message contents and send messages on their behalf.
Code issues a request to a loopback, link-local, or private-range host. This can reach internal services not meant to be exposed and is a common SSRF pivot.
curl http://localhost:18789/health
python -c "import requests; r = requests.get('http://localhost:18789/health'); print(r.status_code)"
### 7. 防火墙配置
The document gives explicit instructions to open a firewall port and enable network access, but it does not warn that doing so can expose the OpenClaw Gateway to other hosts and increase attack surface. In a skill context, operational guidance that changes host firewall posture without security caveats can lead users to unintentionally expose sensitive APIs or monitoring infrastructure.
Commands invoke sudo or root privileges. Verify this elevated access is necessary and justified.
Linux 防火墙:
# Ubuntu/Debian
sudo ufw allow 18789/tcp
# CentOS/RHEL
sudo firewall-cmd --permanent --add-port=18789/tcp
Commands invoke sudo or root privileges. Verify this elevated access is necessary and justified.
Linux 防火墙:
# Ubuntu/Debian
sudo ufw allow 18789/tcp
# CentOS/RHEL
sudo firewall-cmd --permanent --add-port=18789/tcp
Commands invoke sudo or root privileges. Verify this elevated access is necessary and justified.
Linux 防火墙:
# Ubuntu/Debian
sudo ufw allow 18789/tcp
# CentOS/RHEL
sudo firewall-cmd --permanent --add-port=18789/tcp