T09 · Insecure Skill Coding Practices
- Location
music_studio/conversation/engine.py:28- Finding
API Key Is Persisted Verbatim in Conversation History
- Content
View full analysis
None: session = _read_session(sid) now = _now() session.setdefault("messages", []).append({ "role": role, "content": content, "time": now, }) session["updated"] = now _write_session(sid, session) ``` ### Technical Analysis The setup engine records every user message before passing it to the setup flow. At setup step 1, the entire user message is interpreted as the MiniMax API key. Consequently, the key is written verbatim to the conversation session file in addition to its intended storage in `config.json`. This creates an unnecessary secondary credential store under `output/sessions/.json`. Session records are retained for up to 30 days, and the reset implementation does not reliably remove them ...[truncated 1041 chars]- Remediation
View remediation
