T09 · Insecure Skill Coding Practices
- Location
SKILL.md:126- Finding
PostgreSQL Concurrent Index Operations Placed Inside Transaction Blocks
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill is coherent and not deceptive, but its executable PostgreSQL migration examples contain real safety and correctness issues that could disrupt a production migration if copied directly.
Review this skill carefully before relying on it for production database work. It appears intended to help, but treat its SQL as a template requiring DBA review and PostgreSQL-specific correction before execution, especially for concurrent indexes, backfills, rollback steps, and destructive contract phases.
SKILL.md:126PostgreSQL Concurrent Index Operations Placed Inside Transaction Blocks
SKILL.md:183Invalid PostgreSQL Batch Backfill Uses LIMIT Directly on UPDATE
The manifest description says to use the skill when asked to 'plan a database migration,' 'document an expand/contract migration,' or 'coordinate a database schema update with a deployment.' In a markdown/manifest context, this acts like invocation guidance, but it does not define explicit trigger phrases, exclusions, or scope boundaries, making activation conditions somewhat open-ended.
Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
App code change required:
// All INSERT and UPDATE operations must now set BOTH old_column and new_column
// until Phase 3 is complete. This ensures new rows are populated during the backfill window.
Backfill script — batch processing:
No suspicious patterns detected.