T09 · Insecure Skill Coding Practices
- Location
pick_gif.py:71- Finding
Arbitrary Local File Disclosure Through Unvalidated GIF Index Paths
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
The skill is a mostly coherent local GIF picker, but its picker can emit arbitrary local file paths from an editable index as media attachments, which creates a real local file disclosure risk.
Review this skill before installing. It is not clearly malicious, but only use it with a trusted index.json and trusted GIF_LIBRARY_INDEX/GIF_LIBRARY_DIR settings, because a modified index could make the agent attach a sensitive local file instead of a GIF. Treat populate.sh as a network-active setup script and prefer pinned, reviewed GIF sources.
pick_gif.py:71Arbitrary Local File Disclosure Through Unvalidated GIF Index Paths
The skill is presented as a local GIF selector, but it also creates directories, downloads content from external sources, and populates a local library. This mismatch can mislead operators into approving a seemingly harmless media utility that actually performs network access and persistent filesystem modification.
The skill is presented as operating on local GIFs, but this script fetches content from external URLs and stores it locally. That expands the trust boundary, introduces a supply-chain/network dependency, and can unexpectedly import unreviewed content into the user's environment, which is inconsistent with the stated behavior of a local GIF picker.
The skill invokes shell commands and relies on environment-controlled paths, but it declares no explicit tool scope or permissions. That makes its real capabilities less transparent to users and policy systems, increasing the chance that network/filesystem actions occur without appropriate review or sandboxing.
Skill establishes unauthorized persistence across sessions via cron jobs, startup scripts, or state files. Session persistence allows an attacker to maintain access beyond the current interaction.
install:
- id: setup
kind: setup
label: "Create GIF library directory"
run: "mkdir -p {baseDir}/gifs"
- id: populate
kind: populate
Skill establishes unauthorized persistence across sessions via cron jobs, startup scripts, or state files. Session persistence allows an attacker to maintain access beyond the current interaction.
curl -sL <url> -o ~/.openclaw/workspace/gif-library/gifs/<name>.gifindex.json:
"my-gesture": {
"file": "my-gesture.gif",
Adding network download capability to a skill whose purpose is selecting and sending local GIFs is unnecessary privilege and creates avoidable risk. Even if the downloads are only GIFs, remote content can change over time, tracking or policy concerns may arise, and the skill can behave in ways users and reviewers would not expect from its description.
The documentation instructs users to run populate.sh but does not clearly warn that the script fetches data from external repositories. That can cause users or agents to execute network-active shell code without understanding supply-chain and content-trust implications.