Back to skill

Security audit

NiuYao Stock Picker

Security checks for vulnerabilities and agentic risk

Overview

The skill is mostly a coherent stock-ranking tool, but its documented unattended daily push behavior is under-scoped and the shipped script has reliability and disclosure problems users should review before installing.

Review this skill before installing if you do not want unattended financial reports or notifications. Confirm any daily push destination and disable controls, install dependencies in an isolated environment with pinned versions, and treat the generated rankings as informational rather than investment advice.

Vulnerability Patterns
  • Insecure DependenciesIntroduces malicious components through unsafe dependency sources
  • Insecure Skill Coding PracticesFinds exploitable flaws such as hardcoded secrets or command injection
  • Skill Instruction HijackingAlters the agent's session goals or safety constraints when the skill loads
  • Agent Memory PoisoningWrites attacker-controlled rules into memory that affect later sessions
  • Remote Payload Retrieval and ExecutionFetches external code whose behavior can change after review
Findings (2)

T08 · Insecure Dependencies

Warning
Location
README.md:136
Finding

Unpinned Third-Party Dependencies Create a Supply-Chain Risk

Content
View full analysis
Remediation
View remediation

T09 · Insecure Skill Coding Practices

Warning
Location
scripts/niu_yao_v1.py:115
Finding

Unbounded External-Data Retry Loop Can Hang and Continuously Issue Requests

Content
View full analysis
0: checked += 1 if len(df[df['代码'] == code]) > 0: count += 1 except: pass current -= timedelta(days=1) return count ``` ### Technical Analysis The loop terminates only after ten calls return nonempty datasets. The `checked` counter does not advance when the upstream service returns an empty dataset or raises an exception. All exceptions are silently discarded by the bare `except` block. There is no maximum-attempt counter, earliest permissible date, backoff policy, or explicit failure condition. Therefore, persistent upstream failures, throttling, malformed responses, or empty responses can cause the function to iterate indefinitely. Because the function is called for every candidate stock, the issue can prevent the entire scoring operation from completing and may repeatedly contact the external data provider. The repository does not show that an attacker controls the upstream service. Exploitation requires an upstream failure condition or influence over the network responses consumed through `akshare`. ### Attack Path 1. The user invokes the scoring script. 2. The script calls `get_10d_limit_up_count` for a candidate stock. 3. The upstream market-data request persistently raises exceptions or returns empty data. This may result from an outage, throttling, incompatible API output, network interference, or ...[truncated 938 chars]
Remediation
View remediation
Vulnerability Patterns
  • Data ExfiltrationExternal Transmission, Env Variable Harvesting, File System Enumeration
  • Privilege EscalationExcessive Permissions, Sudo/Root Execution, Credential Access
  • Trigger AbuseOverly Broad Trigger, Shadow Command Trigger, Keyword Baiting Trigger
  • MCP Least PrivilegeUnderdeclared Capability, Wildcard Permission, Missing Permission Declaration
  • MCP Tool PoisoningHidden Instructions, Unicode Deception, Parameter Description Injection
Findings (7)

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
94% confidence
Finding

The dialogue trigger phrase '基于最新的股票数据抓牛股复盘一下' is broad and underspecified, making it likely to activate in loosely related finance conversations without clear user intent to invoke this specific skill. In an agent ecosystem, overly permissive triggers can cause unintended tool execution, unexpected data access, or unrequested investment-style analysis, which is especially sensitive in a financial decision-support context.

Content

No source excerpt is available for this finding.

Undeclared Tool Scope

Medium
Category
MCP Least Privilege
Confidence
90% confidence
Finding

The skill documents execution of a local Python script that writes output reports, but the manifest declares no explicit tool scope or permissions. That mismatch weakens least-privilege controls and can allow the skill to perform filesystem writes without clear user or platform visibility into what paths it is expected to modify.

Content

No source excerpt is available for this finding.

Vague Triggers

Medium
Category
Not specified by scanner
Confidence
93% confidence
Finding

The activation text is broad enough to trigger on ordinary stock discussion, including general analysis or model-building conversations. Over-broad routing can cause the agent to invoke this skill unexpectedly, leading to unrequested trading-oriented automation or execution of associated scripts in contexts where the user only wanted discussion.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
88% confidence
Finding

The skill advertises an automatic daily run and push behavior but does not describe consent, destination, data handling, failure modes, or how users can disable it. Any unattended push mechanism can create user-impacting automation, including unwanted notifications, data transmission to external channels, or repeated execution without explicit approval.

Content

No source excerpt is available for this finding.

Intent-Code Divergence

Medium
Category
Not specified by scanner
Confidence
97% confidence
Finding

The module docstring and printed/formatted descriptions repeatedly state the scoring model is composed of six dimensions totaling 100 points. However, the scoring logic adds an undocumented extra 5 points for stocks that hit limit-up on the target day, so actual scores can exceed the documented model and no longer match the claimed weighting.

Content

No source excerpt is available for this finding.

Missing User Warnings

Medium
Category
Not specified by scanner
Confidence
89% confidence
Finding

This Python file performs a filesystem write by creating a reports directory and saving output to a fixed path under /root/.openclaw/workspace/reports. Although it prints a message after saving, there is no user-facing warning beforehand and the top-level usage docstring does not disclose that running the script will create files on disk.

Content

No source excerpt is available for this finding.

Description-Behavior Mismatch

Low
Category
Not specified by scanner
Confidence
84% confidence
Finding

The manifest describes screening A股 short-term momentum candidates and daily scoring/push use cases, but this file also persists results locally under /root/.openclaw/workspace/reports. While report generation is adjacent to the purpose, durable file writing is additional behavior not stated in the manifest description itself.

Content

No source excerpt is available for this finding.